CDR Tickets

Issue Number 4477
Summary Remove unused default template icons
Created 2018-05-23 15:18:10
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2018-05-24 13:28:57
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.226579
Description

There are a few default templates we don't use anymore which can be removed from the default template window. Please remove these from the default template window.

1. GlossaryTerm
2. InScopProtocol
3. OutOfScopeProtocol
4. ScientificProtocolInfo

Comment entered 2018-05-23 17:44:54 by Englisch, Volker (NIH/NCI) [C]

The following files have been removed:

  • GlossaryTerm.css

  • GlossaryTerm_structure.css

  • InScopeProtocol.css

  • InScopeProtocol_structure.css

  • OutOfScopeProtocol.css

  • OutOfScopeProtocol_structure.css

  • ScientificProtocolInfo.css

  • ScientificProtocolInfo_structure.css

  • GlossaryTerm.ctm

  • InScopeProtocol.ctm

  • OutOfScopeProtocol.ctm

  • ScientificProtocolInfo.ctm

  • Cdr/GlossaryTerm.xml

  • InScopeProtocol.xml

  • OutOfScopeProtocol.xml

  • ScientificProtocolInfo.xml

https://github.com/NCIOCPL/cdr-client/commit/29c0cd09

Comment entered 2018-05-23 18:06:57 by Englisch, Volker (NIH/NCI) [C]

, I removed the files for these unused templates but the templates are still available after the restart of XMetaL. Only after removing the template files manually from the local workstation were the options in the 'New CDR document' template gone.
Is there an option to force the deletion of the local files that are not part of the client refresh list?

Comment entered 2018-05-24 06:44:17 by Kline, Bob (NIH/NCI) [C]

The build/deploy process for the release creates fresh directories, so that happens automatically.

Comment entered 2018-05-24 13:28:50 by Englisch, Volker (NIH/NCI) [C]

Great! Then I can mark this task as fixed.

Comment entered 2018-07-12 15:32:05 by Osei-Poku, William (NIH/NCI) [C]

I still see the default templates on DEV.

Comment entered 2018-07-12 15:36:07 by Kline, Bob (NIH/NCI) [C]

That's because we haven't run the deployment script on DEV (or anywhere, really, because we only just now got the final requirements). Because I don't have a lot of time left before leaving town, I'm going to just run the script on QA, and then do it on DEV when I get back.

Comment entered 2018-07-13 22:57:00 by Osei-Poku, William (NIH/NCI) [C]

They still show up on QA.

Comment entered 2018-07-17 12:55:20 by Englisch, Volker (NIH/NCI) [C]

It appears to me that the CdrClient process is properly updating modified files and adding new files but it's not removing outdated files.
I've inspected the manifest file and can confirm that the correct list of documents are listed. The ones we'd like to have deleted like InScropeProtocols, GlossaryTerm, etc. aren't included. I've manually removed the templates from the XMetaL templates directory which will remove them from the list of templates displayed but once the user connects to another server, these templates are restored again and will not be deleted by the CdrClient.
I will take a look at the software but we may need to wait for to update the code.

Comment entered 2018-07-26 07:32:52 by Kline, Bob (NIH/NCI) [C]

The retired templates have been removed from version control and the servers. Because of a bug in the CDR loader users will need to use the script attached to OCECDR-4500 to remove them from their client computers.

Comment entered 2018-08-09 14:51:24 by Englisch, Volker (NIH/NCI) [C]

The templates were removed after running the ising-cleanup.cmd tool on PROD.
Closing ticket.

Attachments
File Name Posted User
Default template QA.png 2018-07-13 22:56:58 Osei-Poku, William (NIH/NCI) [C]
Default templates.png 2018-07-12 15:32:02 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.000673