CDR Tickets

Issue Number 4459
Summary [Glossary] Add Video Link to GTC QC Report
Created 2018-04-19 14:37:35
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2018-04-20 18:09:26
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.224497
Description

Please add VideoLink(s) to both the English and Spanish sections of the GTC QC Report.

You may use Metastasis CDR0000622340 as an example.

Comment entered 2018-04-20 18:09:07 by Englisch, Volker (NIH/NCI) [C]

The following filters have been updated on DEV:

  • CDR339576: Module: InLine Markup Formatter

  • CDR613261: Glossary Term Concept QC Report filter

  • CDR257553: Glossary Term Name with Concept QC Report Filter

, please note that most of the tickets you submitted yesterday require the same filters to be modified. Therefore I will move the changes for all of those affected tickets to the other servers as one. We will also want to run a diff report on QA and preview all of the GTN/GTC filters.

These changes are in my local repository: [cdr4459-gtcall ff5ea69d] (branched from Hawking)

Comment entered 2018-04-25 16:41:02 by Osei-Poku, William (NIH/NCI) [C]

Are the changes ready for testing? I don't see the video in the GTC QC report.

Comment entered 2018-04-25 18:32:25 by Englisch, Volker (NIH/NCI) [C]

Yes, the changes are ready. You won't find the video in the GTC QC Report. I'm treating the video display in the same way as the display for the MediaLink where we're only displaying the content but not the image itself.

The Full Concept QC report, however, displays both, the image and the video link.

Comment entered 2018-04-26 11:18:13 by Osei-Poku, William (NIH/NCI) [C]

Okay. Got it.Thanks!

Comment entered 2018-04-26 11:18:27 by Osei-Poku, William (NIH/NCI) [C]

Verified on DEV.

Comment entered 2018-04-27 18:48:25 by Englisch, Volker (NIH/NCI) [C]

Comparing this report to PROD is looks like this version did show the image after all. I'll have to look at the filter again to find out why the image got dropped.

Comment entered 2018-04-27 18:48:48 by Englisch, Volker (NIH/NCI) [C]

These filter changes have been copied to QA.

Comment entered 2018-04-30 18:56:25 by Osei-Poku, William (NIH/NCI) [C]

So, which version is on QA? The one with the image or without the image? As you can tell we will like to see the image :-).

Comment entered 2018-06-04 17:07:29 by Englisch, Volker (NIH/NCI) [C]

The following filters have been updated on PROD:

  • CDR339576: Module: InLine Markup Formatter

  • CDR613261: Glossary Term Concept QC Report filter

  • CDR257553: Glossary Term Name with Concept QC Report Filter

https://github.com/NCIOCPL/cdr-server/commit/f8c689cb

Comment entered 2018-06-06 14:32:18 by Englisch, Volker (NIH/NCI) [C]

, I had to make some additional changes to some of the filters so that the image and video gets displayed again. Please take another look on QA before I'll copy the filter changes to PROD.

Comment entered 2018-06-06 14:51:07 by Englisch, Volker (NIH/NCI) [C]

The following filters have been updated on QA:

  • CDR339576: Module: InLine Markup Formatter

  • CDR613261: Glossary Term Concept QC Report filter

  • CDR257553: Glossary Term Name with Concept QC Report Filter

https://github.com/NCIOCPL/cdr-server/commit/a8d856476

Comment entered 2018-06-06 16:41:32 by Osei-Poku, William (NIH/NCI) [C]

Looks good on QA.

Comment entered 2018-06-06 17:12:52 by Osei-Poku, William (NIH/NCI) [C]

Looks good on QA.

Comment entered 2018-06-06 17:14:08 by Englisch, Volker (NIH/NCI) [C]

The filters have been copied to STAGE and PROD.
Please verify on PROD and close this ticket.

Comment entered 2018-06-07 12:06:49 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Comment entered 2018-06-07 13:20:51 by Englisch, Volker (NIH/NCI) [C]

, can we close OCECDR-4405 and OCECDR-4460 as well? Those tickets are all related to the GTC/GTN QC reports using the three filters we've updated.

Elapsed: 0:00:00.001335