Issue Number | 4404 |
---|---|
Summary | Remove Unused Filter Sets |
Created | 2018-01-30 12:16:03 |
Issue Type | Improvement |
Submitted By | Englisch, Volker (NIH/NCI) [C] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2018-06-29 15:53:46 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.220420 |
There are a couple of filter sets that aren't of any use anymore and
we want to remove these from being called. In addition, the filter sets
themselves should be removed and any filters used only within these to
be deleted sets.
In cdr.py exists a list of filters called FILTERS which needs
to be updated first and the following sets should be deleted:
QC CTGovProtocols Set
QC GlossaryTerm Set
QC Glossary Term Set (Redline/Strikeout)
QC InScopeProtocol Set
This is an internal nice-to-have ticket I'm adding to Ising and it's the first one to pull in case we're pressed for time.
I've identified the following filter sets we should be able to remove:
CTGov Export Set
CTRP Export Set
Denormalization CTGovProtocol Set
Denormalization InScopeProtocol Set
Mailer InScopeProtocol Set
Mailer Organization Set
Denormalization Organization Set
Mailer Person Set
Denormalization Person Set
QC CTGovProtocol Set
QC InScopeProtocol Admin Set
QC InScopeProtocol Citation Set
QC InScopeProtocol Full Set
QC InScopeProtocol HP Set
QC InScopeProtocol Patient Set
QC InScopeProtocol Set
Vendor CTGovProtocol Set
Vendor InScopeProtocol Set
Vendor QC CTGovProtocol Set
Vendor QC InScopeProtocol Set
QC GlossaryTerm Set
QC GlossaryTerm Set (Redline/Strikeout)
I believe these following filter sets can be removed as well but would like confirmation from ~oseipokuw that these aren't used anymore:
Vendor QC Person Set
Vendor Person Set
QC Person Set
Vendor Organization Set
Vendor QC Organization Set
QC Organization Set
Along with the filter sets the following filterset members should be removed:
CTGov Export Filter (502087)
CTRP Export Filter (685090)
Denormalization Filter: CTGovProtocol (349687)
Module: Denormalize and Upcode Protocol Terminology (350018)
Denormalization Filter (1/1): InScope Protocol (108)
Vendor Filter: InScopeProtocol (150)
Vendor Filter: InScopeProtocol - Sort ProtocolSite (269013)
Vendor Filter: InScopeProtocol - Remove Duplicate ProtocolSite (269012)
CTGovProtocol QC Report (346703)
Module: Protocol Processing Details (463948)
Copy XML for InScopeProtocol Full/Admin (156)
InScopeProtocol Administrative QC Report (123)
Module: InScopeProtocol HP Titles (343577)
Module: InScopeProtocol HP Identification (343575)
Module: InScopeProtocol Administrative Details (343579)
Module: InScopeProtocol Related Links (385703)
Module: InScopeProtocol HP Record Information (343576)
InScopeProtocol HP Citations QC Report (124)
Module: InScopeProtocol HP Abstract (343574)
Module: InScopeProtocol HP Eligibility (466326)
Module: InScopeProtocol HP Details (343573)
InScopeProtocol Full QC Report (155)
Module: InScopeProtocol Patient Abstract (343578)
Copy XML for InScopeProtocol HP (171)
InScopeProtocol HP QC Report (166)
Copy XML for InScopeProtocol Patient (97)
InScopeProtocol Patient QC Report (80)
Vendor Filter: CTGovProtocol (349693)
Glossary Term QC Report filter (90)
Glossary Term QC Report - Redline/Strikeout (453830)
I am uncertain about the following filters which are also members of the filter sets above but may be used otherwise:
Audience Display Filter for QC Report (453864)
Denormalization Filter (1/1): Organization (100)
Copy XML for Organization (315594)
Sort OrganizationName for Postal Address - Organization (315593)
Vendor Filter: Organization (139)
Denormalization Filter (1/1): Person (99)
Copy XML for Person (315572)
Remove Parent OrganizationName for Person (320534)
Vendor Filter: Person (138)
CTGov Export: Remove Inline Markup (517206)
The following filters have been removed on DEV (the first set of filters from the comment above):
: OK
CDR0000502087: OK
CDR0000685090: OK
CDR0000349687: OK
CDR0000350018: OK
CDR0000000108: OK
CDR0000000150: OK
CDR0000269013: OK
CDR0000269012: OK
CDR0000346703: OK
CDR0000463948: OK
CDR0000000156: OK
CDR0000000123: OK
CDR0000343577: OK
CDR0000343575: OK
CDR0000343579: OK
CDR0000385703: OK
CDR0000343576: OK
CDR0000000124: OK
CDR0000343574: OK
CDR0000466326: OK
CDR0000343573: OK
CDR0000000155: OK
CDR0000343578: OK
CDR0000000171: OK
CDR0000000166: OK
CDR0000000097: OK
CDR0000000080: OK
CDR0000349693: OK
CDR0000000090: OK CDR0000453830
The following filter sets have been removed from DEV:
Set,
Vendor CTGovProtocol Set,
Vendor InScopeProtocol Set,
Vendor Organization Set,
Vendor Person Set,
Vendor QC CTGovProtocol Set,
Vendor QC InScopeProtocol Set,
Vendor QC Organization Set,
Vendor QC Person Set,
QC CTGovProtocol Set,
QC GlossaryTerm Set (Redline/Strikeout),
QC GlossaryTerm Set,
QC InScopeProtocol Admin Set,
QC InScopeProtocol Citation Set,
QC InScopeProtocol Full Set,
QC InScopeProtocol HP Set,
QC InScopeProtocol Patient Set,
QC InScopeProtocol Set,
QC Organization Set,
QC Person Set,
Mailer InScopeProtocol Set,
Mailer Organization Set,
Mailer Person Set,
Denormalization CTGovProtocol Set,
Denormalization InScopeProtocol Set,
Denormalization Organization Set,
Denormalization Person Set,
CTGov Export Set CTRP Export
The deleted filters have been removed from github:
https://github.com/NCIOCPL/cdr-server/commit/9efa070
Here are a couple additional filters that are not used anymore:
Denormalization Filter (1/1): Person (99)
CTGov Export: Remove Inline Markup (517206)
Denormalization Filter (1/1): Organization (100)
Copy XML for Organization (315594)
Sort OrganizationName for Postal Address - Organization (315593)
Vendor Filter: Organization (139)
Vendor Filter: Person (138)
Organization QC Report Filter (50)
Person QC Report Filter (96)
The following filters have been removed from the CDR:
: OK
CDR0000000099: OK
CDR0000517206: OK
CDR0000000100: OK
CDR0000315594: OK
CDR0000315593: OK
CDR0000000139: OK
CDR0000000138: OK
CDR0000000050: OK CDR0000000096
The deleted filters have been removed from github:
https://github.com/NCIOCPL/cdr-server/commit/4cac38
~bkline, the filter sets
to be deleted need to be handled as a manual step prior to removing the
filters.
I can run the manual step for QA on Monday.
OK, thanks.
The filter sets have been removed on QA.
The set of filters listed above has been removed from QA with the following output:
CDR0000000050: OK
CDR0000000080: OK
CDR0000000090: OK
CDR0000000096: OK
CDR0000000097: OK
CDR0000000099: OK
CDR0000000100: OK
CDR0000000108: OK
CDR0000000123: OK
CDR0000000124: OK
CDR0000000138: OK
CDR0000000139: OK
CDR0000000150: OK
CDR0000000155: OK
CDR0000000156: OK
CDR0000000166: OK
CDR0000000171: OK
CDR0000269012: OK
CDR0000269013: OK
CDR0000315593: OK
CDR0000315594: OK
CDR0000343573: OK
CDR0000343574: OK
CDR0000343575: OK
CDR0000343576: OK
CDR0000343577: OK
CDR0000343578: OK
CDR0000343579: OK
CDR0000346703: OK
CDR0000349687: OK
CDR0000349693: OK
CDR0000350018: OK
CDR0000385703: OK
CDR0000453830: OK
CDR0000463948: OK
CDR0000466326: OK
CDR0000502087: OK
CDR0000517206: OK
CDR0000685090: OK
The filters listed above have been removed on STAGE. The filter sets have been removed as well.
The filters listed above have been removed on PROD. The filter sets have been removed as well.
These changes are now on PROD.
Closing ticket.
Elapsed: 0:00:00.001304