Issue Number | 4326 |
---|---|
Summary | Modify URL Check Report to create a link to the QC report |
Created | 2017-10-18 12:22:37 |
Issue Type | Improvement |
Submitted By | Osei-Poku, William (NIH/NCI) [C] |
Assigned To | Kline, Bob (NIH/NCI) [C] |
Status | Closed |
Resolved | 2018-04-10 11:28:51 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.215753 |
Please modify the "URL Check" report to create a link to the QC report of retrieved documents using the "CDR ID" column.
Installed on QA.
Verified on QA. Thanks!
When I click on the CDR IDs to get to the QC report, I get
502 - Web server received an invalid response while acting as a gateway or proxy server.
There is a problem with the page you are looking for, and it cannot be displayed. When the Web server (while acting as a gateway or proxy) contacted the upstream content server, it received an invalid response from the content server.
https://cdr-qa.cancer.gov/CdrReports/BrokenURLs-5525.html
This is the link to the latest report.
Fixed on DEV and QA.
It appears for summaries, the CDR Links work for only HP summaries but not for Patient summaries. I get the following error message when I click on a link to a Patient summary QC report.
ERROR:
HP Redline/Strikeout QC Report not valid for patient summaries
Here is the latest run of the report:
~volker: Is there a reason we shouldn't make the QC report script figure out which type of summary it's dealing with instead of having every piece of software that links to the report have to do that?
Tradition? :-)
Isn't the QC report already doing that to some degree?
Don't think so.
https://cdr-qa.cancer.gov/cgi-bin/cdr/QcReport.py?DocId=62681
gets you a page which says
ERROR:
HP Redline/Strikeout QC Report not valid for patient summaries
I guess the real question is: why does the script assume the request is for an HP redline/strikeout report, when the original URL doesn't give any indication that that's what is wanted?
The default for summaries is to run the HP version of the QC report
and this is a patient summary.
In the past we couldn't run patient QC reports for all patient
summaries. Only the "new, reformatted" patient summaries were using the
patient QC report. Those that didn't include KeyPoint titles yet still
needed to run the HP QC report.
Given the fact that you updated the Summary Menu pages to remove the
mention of the old/new patient version summaries we don't have this
distinction anymore and we could pick the QC report version based on the
SummaryAudience but still need to check if the CAM summaries also fall
into the default patterns.
Well, I was hoping for a simple yes/no answer to my original question from this morning, but I confess I don't follow everything in your reply. Do you understand what Volker's saying, ~oseipokuw?
I understand the part recounting the history of why we had to use the HP QC reports for Patient summaries. However, we don't do that anymore so I am not sure why it wouldn't work in the URL report.
OK, so since you're already working on the QC report code, ~volker, please modify it to figure out what the audience is when the document is a summary, and route the request accordingly.
Thanks.
I've updated the QcReport.py. Let me know if this works for you.
https://cdr-qa.cancer.gov/cgi-bin/cdr/QcReport.py?DocId=62681
results in the same error. Also, git pull
didn't result in
any changes.
You must have replaced the version I copied last night with the old one again. I didn't push my changes to github yet because I want make sure my changes are doing what you're expecting.
Can you try again?
The following file has been updated to have the report figure out if a patient or HP version of the summary filters needs to run:
Works now, thanks.
~oseipokuw: please test.
It works well now. Thank you!
Verified on PROD. Thanks!
File Name | Posted | User |
---|---|---|
URL Check link error.JPG | 2018-04-06 15:47:47 | Osei-Poku, William (NIH/NCI) [C] |
Elapsed: 0:00:00.001354