CDR Tickets

There are a few points we should discuss.

• I think the request makes sense but I'm not certain everybody will agree with the change request.

• I'm not certain if the goal is to have the QC report displayed differently or if the goal is to have the Word document display the module data differently. Our past experience has shown that not all CSS is being properly copied to the Word document. So it's possible we're adjusting the QC report but the change will get lost when copying the text to Word.

• Before starting with the report changes I would like to have the formatting agreed on - different color background, different font style, different text color, etc. Would it be OK to loose some of the formatting for the module section?
  Let's first markup a document as a sample. What (hopefully short) summary could I use as a good sample?

~oseipokuw: should we discuss Volker's questions in Thursday's meeting, so they don't fall through the cracks?

~volker: can this go into the release-independent pile?

We had already discussed this ticket but I forgot some of the answers:

• Should the change be visible in the Word document?

• How should the module text be displayed?
  We agreed not to use a grey background and I already started updating the filters on DEV to create a black border around module content, so I'm assuming this type of mark-up was in the running.

~bkline, yes I do believe this is just a filter change unless we want to be able to include an option to turn the new mark-up on/off.

For my information:

• CDR380958: Module: STYLE QC Summary
  The changes are in my trunk sandbox.

... unless we want to be able to include an option...

I'm moving the ticket into the Release Independent sprint since the ticket doesn't mention such a requirement.

◾Should the change be visible in the Word document?

Yes, it should be visible in a Word document.

◾How should the module text be displayed?
We agreed not to use a grey background and I already started updating the filters on DEV to create a black border around module content, so I'm assuming this type of mark-up was in the running.

Users prefer a change in text/font color rather than a border around the text. You may use this Hex color code B4ADAC for the font so we can review to see how it distinguishes the module text from the summary text.

Can this be an option on the report interface? I don't think we will want the module text to always display differently. We try to make those kinds of things transparent to our Board members.

Moving this back into Gauss, then.

Users prefer a change in text/font color rather than a border around the text.

Is the idea to still display red insertion markup red in modules? I'm asking because the requirement to have the module text color change also available in Word presents an additional challenge since this copy/paste process doesn't handle all CSS properly.

Yes. We do not expect anything to change in terms of existing markup colors.

We talked about the possibility of adding text above and below module text to say "[Module Starts Here]" and "[Module Ends Here]", possibly with the name of the module built in. There will be an option of whether to include this text on the QC report interface.

~volker: please assign story points for this ticket.

I'm setting the story points to 5 mainly because the requirements aren't written in stone yet.

We refined the requirements as follows:

1) We will add an option to the QC report interface to display this new module CSS change (see #2). The default will be NOT to display these changes.

2) The optional CSS change will add a box with a broken-line outline around the module text.

3) The CSS of this change should be preserved when users convert the document from the browser (IE) into Word using the "Edit with MS Word" option.

Items (1) and (2) have been setup on DEV. However, figuring out exactly what styles Word will honor once the document has been pasted in is taking some time. Currently, I'm unable to paste the document into Word and keep the style to display the dashed border.

At the moment, the following filters have been modified:

• CDR339576.xml: Module: InLine Markup Formatter

• CDR335166.xml: Module: Checkbox Formatter

• CDR335169.xml: Module: STYLE Default

In addition, the following program has been modified:

• QcReport.py

I'm unable to paste the document into Word and keep the style to display the dashed border.

~oseipokuw, please markup a Word document to display the module in the way you'd like it to come out. I'm sure I will be able to replicate that look with CSS in the browser. I'm certain this approach will be easier than trying to find an appropriate style in HTML that's preserved when copied to Word.

I used Edit with Word function in IE to convert the Unusual Cancers summary QC report (please see attached). I don't see any major problems with that. It actually looks pretty good to me. I can see that tables do not have same consistent background as the the text only sections. Do you expect me to still markup a document or this should be good enough? My opinion is that if the Edit with Word function preservers the module display changes (and it does), then we can always use that function if we want to see the changes in Word.

I don't believe this! I've been trying to convert the document all day yesterday but the dashed line was never preserved for me. We may have different versions of IE or Word. This make me worry that this solution won't last. :-( The next patch of either application might change the outcome.

I did not use the Edit with Word function. Could you please try to copy/paste and let me know if the dashed line is preserved?
If this looks good for you now I'd say we keep it.

Manually copying into Word did not preserve the dashed-lines for me too. However, since it works with when we use Edit with Word, it is okay with us. Thank you!

Thanks for the confirmation, ~oseipokuw. I always thought copying and using the Edit with Word option were the same. We now have another variable to consider. :-)

The following files have been updated in git:

• CDR339576.xml: Module: InLine Markup Formatter

• CDR335166.xml: Module: Checkbox Formatter

• CDR335169.xml: Module: STYLE Default

https://github.com/NCIOCPL/cdr-server/commit/e1127ab [ hawking ]

In addition, the following program has been modified:

• QcReport.py

https://github.com/NCIOCPL/cdr-admin/commit/3d9ba7b [ hawking ]

By the way, I don't have that option Edit with Word and I'm assuming that none of us here at Shady Grove have that option enabled.

https://support.microsoft.com/en-us/help/162059/how-to-configure-internet-explorer-to-open-office-documents-in-the-app

Thanks ~bkline, but the problem is not that a link to a Word document isn't opening the document in MS-Word but the fact that I don't have the option in IE to Edit this document in Word.

Sorry, wrong link.

https://www.youtube.com/watch?v=dvZgqjA5OD4

Yes, that's how you would change the default editor for IE if Word were part of the drop-down list of available editors. I believe I could go into the registry to add Word as another editor option but I'm not certain other users would have the rights to do so. I will submit a ticket to find out why Word isn't currently available.

Are these changes on QA yet? The changes do not show in QC reports.

Sorry, I had forgotten to pass the display module parameter:

• QcReport.py
  https://github.com/NCIOCPL/cdr-admin/commit/dd5eaaa [ hawking ]

• CDR0000339576.xml
  https://github.com/NCIOCPL/cdr-server/commit/2f177b69 [ hawking ]

Verified on QA. Thanks!

Verified on PROD. Thanks!