| Issue Number | 4208 |
|---|---|
| Summary | [DIS] Publishing Filter Update to Allow DrugSummaryRef Element |
| Created | 2017-01-03 13:39:10 |
| Issue Type | Bug |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2017-02-14 14:43:23 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.200860 |
Please update the publishing filter to change DrugSummaryRefs to either Drug Name or Drug Ref elements, whichever is most appropriate.
This is to correct the following problem:
We are getting the following error message when we run Pub Preview of a
DIS that includes a DrugSummaryRef element.
CDRPreview web service error: Xml data validation error,The 'DrugSummaryRef' element is not declared.Validation error occurred when validating the instance document.,2215,4
Thanks!
It appears the drug name gets displayed in italics. Are we OK to display DrugSummaryRrefs in italic?
I think the drug names should be unitalicized.
The drug name is italicized in XMetaL.
On Cancer.gov we're recommending to have the DrugName be displayed without formatting and the DrugRef to be displayed underlined according to our PDQ documentation.
I can't confirm the formatting on Cancer.gov at the moment because Percussion is down on DEV.
Oh - okay. I thought we were talking about Cancer.gov. I think we can live with having the drug name italicized if it's only in XMetaL. Will it be unitalicized in QC reports and Pub Preview?
In PubPreview it'll display just like on Cancer.gov, so it would be displayed underlined and it appears that would be identical to the way that SummaryRefs are displayed.
I'll have to look at the code to see how QC reports are displaying the DrugRefs. Since we haven't been using the DrugRefs in the past I'm guessing we're currently not applying any formatting.
If my stab at an LOE is misguided, please fix, ~volker.
The CDR filter has been updated and PublishPreview is working again. However, the DrugRef (a.k.a. DrugSummaryRef) is not linking to anything and is displayed as plain text.
Although Gatekeeper/Percussion is capable of replacing the CDR-ID
with the proper URL to link to, we have in the past provided this URL to
Gatekeeper in order to speed up the document processing. I've discussed
this with ~learnb and we
agree that in the interest of keeping document processing super fast we
should (or need to) add an url attribute to the DTD and include
the DrugInfoURL value to the DrugRef element.
With this information the processing of the DrugRef element on
Gatekeeper will become a simple XSLT filter change.
Blair, please chime in if I didn't summarize our approach correctly.
The only clarification I'd add is that getting GateKeeper to replace the CDR-ID with the URL directly would require a significant code change. The proposed URL attribute reduces the scope of the GateKeeper change significantly.
I've completed the following changes:
On the CDR side:
Filter change to create the DrugRef element and add the
url attribute
CDR505579.xml - Copy XML for DrugInfoSummary
DTD change to add the url attribute for the
DrugRef element
pdq.dtd
pdqCG.dtd
On the Gatekeeper side:
Replaced the updated DTD (pdqCG.dtd --> pdq.dtd)
Update the filter DrugInformationSummary.xsl
I've published a DIS on BLUE (VeIP - CDR719493) which now shows the
updated links:
https://www-blue-dev.cancer.gov/about-cancer/treatment/drugs/VeIP
Hover over the drug link and look at the URL displayed at the bottom of your browser. An updated document will display the server as as www-blue-dev.cancer.gov instead www.cancer.gov and the link will display _https://_ at the beginning of the URL.
I still need to update all modified filters/files in subversion.
The following filter has been modified to add the DIS URL for DrugSummaryRefs:
R14558: CDR505579 - Copy XML for DrugInfoSummary
Versioning modified DTD:
R14559: pdq.dtd
R14559: pdqCG.dtd
Verified on DEV (using PP).
Verified on QA (using PP).
Elapsed: 0:00:00.001377