CDR Tickets

Issue Number 4068
Summary Change CAM Board Name - More Filter Changes
Created 2016-03-31 11:54:34
Issue Type Task
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Shah, Aarti (NIH/NIDDK) [C] [X]
Status Closed
Resolved 2016-04-15 12:46:52
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.181566
Description

Volker identified additional filter changes that will be needed due to the CAM Board name change.

I just came across the old CAM name in a QC filter which means there are additional filter changes necessary.

  • CDR0000335424.xml - Denormalization Filter: Summary

  • CDR0000339576.xml - Module: InLine Markup Formatter

Comment entered 2016-03-31 13:46:06 by Learn, Blair (NIH/NCI) [C]

From status meeting: Adjust names for miscellaneous documents.

Comment entered 2016-04-01 15:28:33 by Juthe, Robin (NIH/NCI) [E]

There are additional misc doc type name changes described in OCECDR-4047 that the filter will need to be adjusted to accommodate.

Comment entered 2016-04-12 14:04:29 by Englisch, Volker (NIH/NCI) [C]

I'm re-assigning this back to Aarti. Both of the filters that need to be modified Aarti is already making changes to. Since this should only be a string change I'll have you do these to avoid the possibility of SVN conflicts.

Comment entered 2016-04-13 10:08:37 by Shah, Aarti (NIH/NIDDK) [C] [X]

What does ICAT stand for?

Comment entered 2016-04-13 10:11:10 by Juthe, Robin (NIH/NCI) [E]

Hi Aarti - IACT stands for Integrative, Alternative, and Complementary Therapies. It's basically an internal abbreviation (not a common acronym) for the new name of the former CAM Board.

Comment entered 2016-04-13 10:16:36 by Shah, Aarti (NIH/NIDDK) [C] [X]

Thanks Robin. Will the summary type in the summary metadata read Integrative, Alternative, and Complimentary Therapies instead of Complimentary and Alternative Medicine? Since, the code relies on string comparison, I wanted to make sure we capture the text correctly.

Comment entered 2016-04-14 13:45:55 by Juthe, Robin (NIH/NCI) [E]

From status meeting: Need to look at CDR157 (check for misc docs related to CAM)

Comment entered 2016-04-15 12:19:07 by Englisch, Volker (NIH/NCI) [C]

The misc. doc in question is CDR445622. The filters aren't using the document by its name and the MiscDocumentType element isn't used either. So the misc. docs changes won't affect these summary changes as far as I can tell.

Comment entered 2016-04-15 12:48:13 by Shah, Aarti (NIH/NIDDK) [C] [X]

Filter changes completed on Dev for:

CDR0000335424.xml - Denormalization Filter: Summary
CDR0000339576.xml - Module: InLine Markup Formatter
CDR0000000157.xml - Vendor Filter: Summary

Comment entered 2016-04-15 12:53:19 by Juthe, Robin (NIH/NCI) [E]

There were other misc docs whose name and/or type changed, so I just want to be sure all bases are covered. (CDR445622 was the one that I updated manually. And I just updated the Spanish equivalent misc doc manually too.) Here's a complete list of docs touched by Bob's global (the last two are blocked docs so are irrelevant). I starred the docs that had additional changes since you completed the filter changes in IT1 (OCECDR-4045).

CDR0000256925 - For More Information (type changed)
CDR0000445623 - To Learn More (type changed)
CDR0000446984 - To Learn More - Spanish (type changed)
CDR0000445621* - About CAM (type changed)
CDR0000445622* - Questions to Ask... (type changed manually)
CDR0000446985* - About CAM - Spanish (type changed)
CDR0000446986* - Question to Ask... - Spanish (type changed manually)

CDR0000766007 - About Cam - Spanish [BLOCKED] - irrelevant
CDR0000766008 - Questions to ask... - Spanish [BLOCKED] - irrelevant

Comment entered 2016-04-15 12:54:11 by Juthe, Robin (NIH/NCI) [E]

I see that these filter changes are done, so I can take a look at a few summaries in PP on DEV later this afternoon and see if any of these sections are missing.

Comment entered 2016-04-15 13:08:23 by Shah, Aarti (NIH/NIDDK) [C] [X]

Thanks Robin.

Comment entered 2016-04-15 13:20:49 by Englisch, Volker (NIH/NCI) [C]

so I can take a look at a few summaries in PP on DEV

Unfortunately, that won't work yet. The changes require a DTD change which is not in place yet. I'll take a look if I can add quickly.

Comment entered 2016-04-15 14:28:52 by Englisch, Volker (NIH/NCI) [C]

The DTD has been updated and you can run PP on DEV, Robin.

Comment entered 2016-04-15 15:35:45 by Juthe, Robin (NIH/NCI) [E]

Robin B and I just reviewed the CAM summaries together and the sections in misc docs are all there as expected so this is verified on DEV. Thank you!

Comment entered 2016-04-15 15:40:44 by Englisch, Volker (NIH/NCI) [C]

Super! Thank you for checking!

Comment entered 2016-04-18 09:58:12 by Shah, Aarti (NIH/NIDDK) [C] [X]

- thank you for testing on Dev.

Comment entered 2016-04-26 09:11:09 by Juthe, Robin (NIH/NCI) [E]

We are seeing the heading "Current Clinical Trials" without any content beneath it at the bottom of the Milk Thistle Patient summary in Publish Preview. I'm not sure if this is related to these changes. I'll post a screenshot. It is not on the live site. Thanks.

Comment entered 2016-04-26 10:59:56 by Englisch, Volker (NIH/NCI) [C]

I'm assuming this is a data issue. I'll take a closer look on how the Current Clinical Trials section gets created.

Comment entered 2016-04-26 11:05:08 by Englisch, Volker (NIH/NCI) [C]

Yes, this is a data issue.
The summary contains an empty section with the title Current Clinical Trials and a comment "added per RB for international trials 11/14/11".

Comment entered 2016-04-26 11:07:27 by Juthe, Robin (NIH/NCI) [E]

Ah-ha, that explains it. Thanks, Volker.

Comment entered 2016-04-28 13:09:13 by Juthe, Robin (NIH/NCI) [E]

Verified on QA.

Comment entered 2016-06-15 09:51:05 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD

Attachments
File Name Posted User
screenshot-1.png 2016-04-26 09:11:37 Juthe, Robin (NIH/NCI) [E]

Elapsed: 0:00:00.001864