| Issue Number | 3954 |
|---|---|
| Summary | [Glossary] GTC by Spanish Definition Status Report - Display Comments |
| Created | 2015-08-13 12:54:59 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2015-11-18 16:09:53 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.167485 |
Linda would like to have a new column added to this report. The new column should be named "Comment" and display the most recent comment in the translated term definition block.
She would also like the report to display comments that have been added within the translated term definition block in the definition column.
Let's make sure I've got this right: I'm supposed to display all the
comments in
/GlossaryTermConcept/TranslatedTermDefinition/Comment
elements in the "Definition (ES)" column (presumably appended to the
definition text, identified in some way as comment) and
repeat the most recent comment in the new "Comment"
column. Is that right? The "date" attribute of the Comment element is
optional. How shall I know which is the most recent comment?
ignore comments that don't have the date
attribute?
assume the last comment is the most recent?
assume the top-most comment is the most recent?
some other method?
Thanks.
~oseipokuw, can you please confirm these requirements with Linda?
#3 is correct. The recent comment is the one on top.
There's more than one question in my previous comment.
Can you elaborate on the other question? I don't understand why you presume that the comment is appended to the definition text. Also, I don't understand why you need to "repeat" the comment instead of just display the most recent comment from the Comment field in the TranslatedTermDefinition block. The way I understand it is that (and I am not sure if it is correct) the TranslatedTermDefinition block has a child "Comment" element which should be displayed (the most recent comment) in the new column whenever it is present in the data. Linda just went offline, I will send her an email for her to provide more information to answer your question.
Here's what the description of this ticket says:
Linda would like to have a new column added to this report. The new column should be named "Comment" and display the most recent comment in the translated term definition block.
So I take the most recent comment (the first one in the set that I find, according to your earlier reply) and put it in the new column.
She would also like the report to display comments that have been added within the translated term definition block in the definition column.
This second request tells me to take all of the comments from the same translated term definition block and also put them in the existing "Definition" column on the report.
I don't understand why you presume that the comment is appended to the definition text.
Well, I'm just guessing. I could put the comments before the definition instead of after it, but if I do what the request above asks me to do, I've got to put it somewhere in that column, right?
Okay, thanks! I will discuss the requirements with Linda and update the issue.
I have implemented the enhancements as requested in the original description (on DEV).
Linda looked at the report and all she wants is just the newest comment in the new comment column. She does not need a history of the comments appended to the definition text.
Changes to Spanish definition column backed out.
Verified on QA (per Amy).
Verified on PROD. Thanks!
Elapsed: 0:00:00.001317