CDR Tickets

If we make this an Excel report (and we came up with a bunch of reasons this would make sense), we will use the xlwt module instead of the home-grown ExcelWriter module.

Re-assigning this to Volker since he wrote the original report and knows just what to do.

Am I correct that the information of these new columns would only be displayed on the summary sheet version of the report and the non-summary sheet portion of the report does not change?

Yes, that's correct. We're only modifying the summary sheet version of the report to add these new columns when selected.

Both reports display the board manager information at the bottom of the report. I'm not sure how you would like to handle this address block for the summary sheet in Excel format.
I see several options:

1. drop the board manager address block for the summary sheet (HTML and Excel version)

2. drop the information for the Excel version only

3. include that information on a separate Excel sheet (and keep it on the HTML version)

4. Other?

Good question. Let's go with #1 and drop the Board manager block from the summary sheet. I always end up deleting that block from the summary sheet version anyway, and I suspect others do the same given the purpose of the summary sheet. Thanks.

Perfect! The option #1 was my favorite option anyway.

Do we still want the Blank Column or can we drop this one with the ability to create the report output in Excel? If we do want to keep the ability to add a blank column, do we want to have the ability to create multiple blank columns for the HTML version (this option isn't needed for the Excel version).

Robin, I think I'm finished with the changes to this report but before I put it back to subversion I'd like you to have a look to make sure this is what you expected.
Please access the report on DEV using the following URL
https://cdr.dev.cancer.gov/cgi-bin/cdr/BRBK.py
(I will rename this once I know everything appears to be working correctly.)

We already talked about the difficulty of specifying the width of each of the individual column cells without knowing (a) the number of columns to be included and (b) the width of the content of those included columns, not to mention the width of the browser window when the report is run.

I've made some basic assumptions which I hope will work for most of the users most of the time. Here is what I'm doing to address the issue:

1. The first column (Name) has a fixed width of 250 pixels

2. All other columns are automatically set by the browser^^ - provided no blank columns are added

3. If blank columns are added I'm testing how many columns are being displayed and split the remaining width equally between the blank columns to be displayed.

4. As a special treat for you I'm also allowing you to specify the width of the blank columns. If you enter a colon character ':' I will use all following values (separated by space) as the specification for the width (in pixels) of the column(s). So, a value of '3:30 60 90' will display three blank columns, the second twice as wide as the first and the third three times the size of the first.

Since the creation of the summary sheet has been completely rewritten - using Bob's new HTML builder library - you may want to test as many different options as possible once the report has been copied to QA.

^^ Typically, the browser makes a table column as wide as it needs to be in order to display the content of the widest element of that column provided the page width allows this. If the page is not wide enough for all columns to be displayed that way the column width is adjusted to allow all columns to be displayed on a page. I'm not really sure what rules the browser is using for shrinking table columns.

Still reviewing this, but I've noticed a few things (as mentioned in today's status meeting):

1. Term End Date. This should be a calculation of the term start date + the term renewal frequency. It is NOT the same as the termination date.

2. Please add gridlines to the excel report if possible.

3. Please investigate using single gridlines (as opposed to double lines) in the HTML version of the report.

I've talked to Robin regarding a few differences between the old and the new (BRBK3.py) report:

• The old report displays an 'Inactive' board on the options list but the new one does not (only Active boards are displayed). I kept the inactive one because I didn't want to have a particular board pre-selected (we're not playing any favors :-) ) but Robin says it's OK to keep the first element of the list selected.

• The old report didn't dedupe phone numbers but it's OK to remove duplicates.

• When starting the report please make the Full version the default and also display the options for the full version. Currently the options are only showing when the format is selected.

... Robin says it's OK to keep the first element of the list selected.

Does either of you (or do both of you) like it better now, with the "prompt" entry inserted at the top (this is in the BRBK3.py variant of the report)?

...make the Full version the default...

Done (in the BRBK3.py fork; I'll let Volker fold in as much from this variant as he wants).

Please add gridlines to the excel report if possible.

Borders have been added to the Excel report cells.

Does either of you (or do both of you) like it better now, with the "prompt" entry inserted at the top

Yes, I do. You have my vote.

I noticed one more change to the old report:
On the old one only the Name field was always displayed on the summary sheet and the Phone column was checked by default. Bob's version has the Phone, Email, and CDR ID checked by default.
Robin may wants to weigh in which fields should be selected. My feeling is that the CDR ID may not be used frequently.

I'll let Volker fold in as much from this variant as he wants

Bob, your version is clearly better than mine as it is faster, has fewer bugs, is prettier, and with 30% fewer lines of code it is simpler, more compact, and easier to read.
Although I feel a bit like I wasted my time with the report it would be silly not to use your version and that's what I will do.

I'm copying the version back to the original name BoardRoster.py. Any additional changes should be made to that file.

Term End Date. This should be a calculation of the term start date + the term renewal frequency. It is NOT the same as the termination date.

I've added the calculated Term End Date. However, there is still a question regarding the output format of the date. Since this is a calculated field instead of a field from the document I'm not using our default 'YYYY-MM-DD' format.
Please let me know if you'd prefer that format instead.

... My feeling is that the CDR ID may not be used frequently.

Volker:

Go ahead and modify the default selections (unless you'd prefer that I do that).

I'll do the change but I'll have Robin tell me first if she has a preference.

Where should I be reviewing this report now? The BRBK and BRBK3 links aren't working for me any more (I'm getting a 502 error message). I tried the board roster report from the OCCM board manager page, but the summary options won't expand. I'll respond to the question of defaults as soon as I'm able to view the full list of options on the report 🙂

If you're running the report in IE could you run it with Firefox or Chrome?

The regular BoardRoster report from the board manager page is the one you would want to look at again.

It works in chrome.

Please select phone & email as the default. No CDR ID.

Please format the term end date as a "cdr date" - YYYY-MM-DD - so that we can use that for sorting purposes.

Since the term end date is calculated, maybe we should make that clear on the report selection page. Could you please add "(calculated using the term renewal frequency)" after Term End Date? Let me know if that's too long.

Thanks!

Since the term end date is calculated

Would you like the date to be displayed in italics, green, blinking, etc.?

Oh I suppose we'll just go with boring old black text. But thank you for the offer 🙂

Oops, I better take the italic font out again. Unless you would like another peek.

Looks good! Keep the italics. They will be a reminder that this is a calculated field.

I've run many combinations of this report and it's looking really good in HTML. However, I'm getting an error when I try running the Excel version:

"Duplicate headers received from server"

Additional info for Bob:
The report works fine in FF but not in Chrome. This is the full error message from Chrome:

The response from the server contained duplicate headers. This problem is generally the result of a misconfigured website or proxy. Only the website or proxy administrator can fix this issue.
Error code: ERR_RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION

Robin, I was wrong. This has nothing to do with the table caption that I mentioned.

Saving the current version in subversion:

• R12550: BoardRoster.py

Fixed the problem with the "Duplicate headers ..." message.

Verified on DEV in Chrome and Firefox. This report doesn't work in IE - the list of summary options doesn't expand.

This report doesn't work in IE - the list of summary options doesn't expand.

Please try refreshing the report request form by holding down the shift key while clicking on the refresh icon and see if that solves the problem. If it doesn't I'll come by and take a look when we're both next in the office together.

Aha! I found (yet another) bug in IE. Workaround installed.

• R12582 /trunk/Inetpub/wwwroot/cgi-bin/cdr/BoardRoster.py

Verified in DEV in IE. Thanks!

As we found with other reports, the copy/paste into Word is better with Chrome or Firefox. Just making a note for testing on QA.

Another note for testing on QA: The Excel report must be run in Chrome or Firefox.

Noticed something odd on QA. The assistant e-mails pull in fine on the web page version of the report, but the same column is blank in Excel.

That is indeed odd and what's even more odd is that I don't see it. :-)
I ran it for the Supportive Care Board choosing Email, Phone, Assist. Name, Assist. Email as columns.

What settings did you use? In the meantime I'm using a couple more different settings.

I used Genetics, Contact Mode, Assist. Name, Assist. Email.

I have both versions (HTML & Excel) with these selections on my screen in case you want to see.

Marking this QA verified since we determined that the missing data problem was an issue with protected settings within Excel. We'll need to update those settings on Prod either individually or ask CBIIT to change these settings on the Bastion.

The new report is in production (Yeah!). Unfortunately, I noticed that we forgot to add some instructions/hint to let the users know about the feature allowing them to add new columns and specify the size of those columns (by adding a colon and the column size after the number of additional columns).
We may want to add that for our Ampere release.

The interface for this report is messed up also. (See OCECDR-3704) These look to be related. I've attached a screenshot.

I ran the report both on IE and FF and it looks OK. I'll come over tomorrow to look at your settings. Could it be that you have compatibility mode on?

It was the compatibility mode. Looks good now!

Verified on prod.