| Issue Number | 3715 |
|---|---|
| Summary | [Genetic Professional] Filter to sort Family Syndromes |
| Created | 2014-02-07 13:17:12 |
| Issue Type | New Feature |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2014-02-17 16:36:10 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.118246 |
I am creating this ticket for discussion and possibly add to the next CDR release.
We need a macro to alphabetically sort the syndromes in the GP
documents. When a document is newly created or the familial syndromes
are newly added, they are correctly sorted alphabetically, when the CTRL
+ Enter macro is used to add them. With time as the document is
continually updated, the order is not retained unless users are careful
to manually maintain the order. Meanwhile, Cancer.gov publishes the
document in the same order we present to them. It will be helpful to
have a macro that can order the syndromes alphabetically after they have
been added or updated. Alternatively, this may be handled in the vendor
filters.
Example:
http://www.cancer.gov/cancertopics/genetics/directory/view?personid=664841
We decided to do this in the vendor filter.
easier to implement
follows the fundamental principle of changing data as far downstream as possible
avoids the problem of forgetting to use a macro
The filter will also check for and eliminate duplicates from the output.
William, could you please give me one of two samples that I could look at?
Try these two:
664841
664996
I will add another one shortly.
664784
The following filter has been modified in order to sort the entries of the Family Cancer Syndrome:
CDR660145: Copy XML for GeneticsProfessional
Please review on DEV and then I will run a diff report on QA.
William, did you say at last weeks meeting you already checked the filter changes? I'm not sure if I can go ahead and run the diff reports on QA.
No. Not yet. I am still testing it. I will post a comment when I am done.
The sorting is working correctly. You may proceed to run the diff on QA.
It looks like the filter is not checking for duplicates. Could you please take a look?
That's correct. I missed the request for removing duplicates.
Do your samples include duplicates? If not could you please adjust the documents accordingly?
All three samples adjusted accordingly.
Thanks, William.
The filter has been modified to remove duplicate cancer syndrome
blocks now.
This is ready for review on DEV.
Duplicate syndromes are now removed in pub preview.
Verified on DEV.
I've ran a diff report on QA and identified 21 documents for which duplicates were removed.
The following filter has been updated:
R12419 : Copy XML for GeneticsProfessional (CDR660145)
Please review on QA before I'll update the filter on PROD.
Verified on QA. Thanks!
The modified filter to sort and de-dup Family Syndromes has been installed on PROD.
Please verify and close this bug.
William, can this issue be closed?
Yes, we can. I will go ahead and close it. Thanks!
Elapsed: 0:00:00.000744