| Issue Number | 3602 |
|---|---|
| Summary | [GenProf] Email notification issues |
| Created | 2013-03-26 15:37:13 |
| Issue Type | Improvement |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2013-09-03 16:47:48 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.107930 |
BZISSUE::5301
BZDATETIME::2013-03-26 15:37:13
BZCREATOR::William Osei-Poku
BZASSIGNEE::Bob Kline
BZQACONTACT::William Osei-Poku
Sometimes when we receive email notifications for completed mailers, they do say that the mailers have changes and they provide a link but when you click on the link a marked as bounced after the expiration date.
"No changes" text is displayed. Please see example below:
From: GeneticsDirectory@cancer.gov GeneticsDirectory@cancer.gov
Sent: Thursday, December 09, 2010 3:16 PM
To: NCIGeneticsDirectory
Subject: GP mailer 690966
GP mailer 690966 (Person CDR665105) was reviewed and submitted with changes which can be reviewed at:
http://pdqupdate.cancer.gov/PDQUpdate/cgi-bin/ShowGPChanges.py?id=690966
BZDATETIME::2013-04-30 17:20:37
BZCOMMENTOR::Bob Kline
BZCOMMENT::1
That's what happens when the user doesn't actually make any changes, but still clicks the "Please update my profile with the changes I have made" (instead of the one marked "No changes are required"). Not sure what to do about that.
BZDATETIME::2013-05-08 17:14:10
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::2
Please look into the possibility of only enabling the "Please update my profile with the changes I have made" button when a user has actually made a change. Alternatively, depending on when and how you're checking for submitted changes, you may discard the response from a user if there are no changes and yet the user had clicked on the button to update his or her profile, and just report that there were no changes.
[Bob] I'm going to go with the solution of determining whether any changes have been made at the point of storing the results.
The software now ignores which button the user clicked. This means that in addition to the change to the email notification message sent to CIAT, the program will now enforce form validation rules even when the user clicks the button saying there were no changes. Ready for testing (on DEV).
Files affected:
gpmailers/cgi-bin/cgsd.py (r12005)
I need to generate a few mailers on DEV to test this. Do I need to change the email addresses of the professionals to mine before generating the mailers?
That shouldn't be necessary, assuming the servers are set up properly and the software does what it's supposed to. However, it wouldn't be a bad idea to confirm these assumptions by creating a single mailer for a document whose address has been set to a bogus value (I use "klem@kadiddlehopper.com" for such purposes, but you can use anything you want, as long as it's not a real email address). After you've confirmed that the emailer request has been submitted, I'll run the cron job by hand, and if things are working properly, you, Margaret, and I should get the mailer message.
Done. I just generated a mailer for - CDR0000664598.
It works as expected. Thank you!! I assume that the GPEmailers list will get updated after the cron job kicks in later tonight? I am asking because I didn't see the rows for the mailers I responded to, I had to copy the links from my emails to DEV to review.
Right. The generation of the email message and loading of the mailer are handled by the cron job. The updating of the status in the mailer tracking documents for completed/expired/bounced mailers is kicked off by the Windows scheduler each night.
Have you had a chance to confirm that the GPEmailers list was updated as you expected?
Yes. It was updated as expected.
Verified on Prod.
Elapsed: 0:00:00.000579