| Issue Number | 3330 |
|---|---|
| Summary | [Summaries] Changes to Board Roster Reports |
| Created | 2011-03-23 17:15:05 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2011-05-23 13:57:28 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.107658 |
BZISSUE::5023
BZDATETIME::2011-03-23 17:15:05
BZCREATOR::Robin Juthe
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku
We would like to add information about govt employee status and receipt of honoraria to the existing "summary sheet" for the PDQ Board Roster report. Since we think there could be instances where we'd want to know the govt employee status OR the honoraria information, and these can differ, we would like to add 2 new checkboxes to the summary sheet list:
Government Employee
(this column would be populated with 'Yes' or 'No' based on the value in
the Govt Employee element in the Board member document.)
Receives Honoraria
(this column would be populated with 'Yes' or 'No' based on the govt
employee status and the presence of the HonorariaDeclined element - I
can describe this further if needed.)
It would also be useful to have the ability to create a summary sheet for all PDQ Board members so that Victoria can share this report periodically with Robyn Bason. Is there a reason why the all PDQ Board roster report has a separate interface? Could it be included in the same report and have the same options as far as creating a summary sheet with various options, showing subgroup info, etc.?
BZDATETIME::2011-04-18 18:18:10
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1
(In reply to comment #0)
> - Government Employee
> (this column would be populated with 'Yes' or 'No'
A valid value for this field is 'Unknown'. How would you like to handle this for the report?
> based on the presence of the HonorariaDeclined element
I'm blind and can't find this. Is this an element, attribute,
other?
I don't find it in the schema on MAHLER.
BZDATETIME::2011-04-18 21:11:00
BZCOMMENTOR::Robin Juthe
BZCOMMENT::2
(In reply to comment #1)
HonorariaDeclined is an attribute on the GovtEmployee element. Could it be that it's only on Franck and Bach? I think we were adding this element and attribute at the time Mahler was down.
Please populate the government employee column with "Yes", "No", or "Unknown". Thanks.
BZDATETIME::2011-04-19 11:37:35
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3
(In reply to comment #0)
> Is there a reason why the all PDQ Board roster report has a
> separate interface?
Yes. If I remember correctly the problem was the specific sorting for
the Board Roster Report since it displays the Editor-in-Chief first and
then all board members alphabetically by board while the full Board
Roster Report displays all persons alphabetically. Because of the
special sort-order display (and likely a comment such as "We won't ever
need a combined full report") the report was written to only worked for
a single board.
In addition, there was a requirement to display the Full Board Roster
Report in either HTML or Excel format. Since the original Roster Report
hadn't been written with the Excel option or the Full Roster option it
was much simpler to just create an individual report for the Full Board
Roster Report.
> Could it be included in the same report and have the same
> options as far as creating a summary sheet with various options,
showing
> subgroup info, etc.?
To be clear are you asking to include the option for a "full summary sheet" in the Board Roster Report (by board) or the Full Board Roster Report, or are you asking to combine the Board and Full Board reports?
I would guess that this (any of the above) can be done, however, I'm not sure if it can be done simply by adding another option to the report. It's possible that the report would have to be rewritten in it's entirety. I would need to look at how both reports are working currently.
BZDATETIME::2011-05-06 14:09:50
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4
(This was the report I was about to submit shortly after Verdi and Schubert broke. If I'm lucky the comment will be accepted now.)
I have modified the summary sheet for the board roster report to include the GovernmentEmployee and HonorariaReceived columns.
We were talking about a full summary sheet to be attached to the Full Roster report. Are we going to add a separate issue for that or include the changes here?
This report is ready for review on MAHLER.
BZDATETIME::2011-05-06 14:17:50
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5
Robin and I talked about the report and if I remember correctly we
had said that by default a government employee will not receive a
honorarium. This information would only be of value for non-government
employees and of those only very few would decline to receive a
honorarium.
We therefore discussed to drop the 'Rec. Honor.' column altogether, mark
the 'decliners' with an asterisk and add a little footer to the table
like
*: Declined Honorarium
Am I remembering this correctly, Robin?
BZDATETIME::2011-05-06 14:26:40
BZCOMMENTOR::Robin Juthe
BZCOMMENT::6
(In reply to comment #5)
> Am I remembering this correctly, Robin?
That is correct. I'll add a separate issue about the full roster report.
BZDATETIME::2011-05-09 16:34:32
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7
The changes have been implemented and copied to FRANCK for testing.
BZDATETIME::2011-05-18 10:09:29
BZCOMMENTOR::Robin Juthe
BZCOMMENT::8
(In reply to comment #7)
> The changes have been implemented and copied to FRANCK for
testing.
This doesn't seem to be pulling the info from the latest version of the board member information docs. I'm seeing "unknown" for everyone's govt employee status, but the elements are populated with real data since Franck was refreshed recently.
I'm also thinking we probably don't need the superscript "N/A" for those members who do not have the honoaria declined attribute since that applies to everyone except 1 person. There can be an asterisk for that member and nothing except the employee status for everyone else.
BZDATETIME::2011-05-18 10:13:10
BZCOMMENTOR::Volker Englisch
BZCOMMENT::9
We had refreshed the CDR data on FRANCK and what you're seeing is
probably a result of the query_term table not being properly
populated.
Give me a moment - I will have to re-index the document type for the
report to look OK again.
BZDATETIME::2011-05-18 10:37:50
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10
Robin, please try again. The documents have been re-indexed.
BZDATETIME::2011-05-18 12:47:57
BZCOMMENTOR::Robin Juthe
BZCOMMENT::11
This looks good. I have a few small requests though:
1. Could we only display the "honorarium declined" footer when the "government employee" box is checked? It is irrelevant otherwise.
2. Could the footer text read "honoraria declined" rather than "honorarium...". Nit-picky, I know. It's just that it refers to a decision about all honoaria - not a one-time thing.
3. Could we remove the "N/A" for the unknown folks? I'd prefer to either have the asterisk or nothing at all.
Thanks!
BZDATETIME::2011-05-23 12:29:47
BZCOMMENTOR::Volker Englisch
BZCOMMENT::12
(In reply to comment #11)
> This looks good. I have a few small requests though:
The changes are ready for review on FRANCK.
BZDATETIME::2011-05-23 13:37:34
BZCOMMENTOR::Robin Juthe
BZCOMMENT::13
(In reply to comment #12)
> (In reply to comment #11)
> > This looks good. I have a few small requests though:
> The changes are ready for review on FRANCK.
All looks good! Please promote these changes to Bach.
BZDATETIME::2011-05-23 13:45:54
BZCOMMENTOR::Volker Englisch
BZCOMMENT::14
The following report has been copied to FRANCK and BACH:
BoardRoster.py - R10092
Please verify on BACH and close this bug.
BZDATETIME::2011-05-23 13:57:28
BZCOMMENTOR::Robin Juthe
BZCOMMENT::15
(In reply to comment #14)
> The following report has been copied to FRANCK and BACH:
> BoardRoster.py - R10092
> Please verify on BACH and close this bug.
Verified on Bach. Closing issue. Thank you!
Elapsed: 0:00:00.000577