CDR Tickets

Issue Number 3326
Summary [Summaries] Ordered List Style Problem
Created 2011-03-18 10:09:55
Issue Type Improvement
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2011-04-11 17:32:52
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107654
Description

BZISSUE::5019
BZDATETIME::2011-03-18 10:09:55
BZCREATOR::Robin Juthe
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

There's a bug in the CDR whereby a style is not defined for an ordered list that is entered using the element list as opposed to the icon at the top of the screen. This has caused a list not to appear in a QC report. Victoria's email below explains the issue in more detail:

Hi Margaret and Robin,

I had a problem with a document in the CDR and Volker suggested I write to you so one of you can put in an issue about it. Barry and I noticed that some text was missing from the GTT summary he revised. It was an ordered list in approved insertion and it looked fine in the CDR. But when I ran the bold/underline report, it didn’t show. Volker figured out that the style hadn’t been defined for it. Then we figured out that the list must have been added from the element menu on the side instead of from the menu bar on the top. When you choose an ordered list from the top menu bar, a default style is assigned. When you choose a list from the element box, no style is assigned. I always use the links at the top for lists (as a result of a long-ago meeting we had where we discussed which links to use) but Louise added this text and must have chosen the list from the element. Anyway, Volker said if you put in an issue he can change it so an element is assigned when a list is chosen from the element box.

Thanks!
Victoria.

[Volker, please revise the component if necessary. Thanks.]

Comment entered 2011-03-18 12:23:29 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-03-18 12:23:29
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

I've modified the OrderedList template to include the Style attribute.

I also looked at other templates and added (for both the OrderedList as well as the ItemizedList) a style attribute where it was missing.
Also, I noticed that the ItemizedList tag color is dark blue while the tag color for OrderedList elements is gray. I'm guessing that this was an oversight and I adjusted the tag color to be the same for the list elements since the ListItem elements are sharing the same color as well.

Last not least, I've adjusted the tag color for the SectMetaData element to be slightly greenish since yesterday was St. Patrick's Day. :-)

This is ready for review on MAHLER.

Comment entered 2011-03-22 17:36:34 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-03-22 17:36:34
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::2

(In reply to comment #1)
> I've modified the OrderedList template to include the Style attribute.
>
> I also looked at other templates and added (for both the OrderedList as well as
> the ItemizedList) a style attribute where it was missing.
> Also, I noticed that the ItemizedList tag color is dark blue while the tag
> color for OrderedList elements is gray. I'm guessing that this was an
> oversight and I adjusted the tag color to be the same for the list elements
> since the ListItem elements are sharing the same color as well.
>
> Last not least, I've adjusted the tag color for the SectMetaData element to be
> slightly greenish since yesterday was St. Patrick's Day. :-)
>
> This is ready for review on MAHLER.

Verified on Mahler. I tested with QC reports and they all worked fine. However, I was unable to test with pub preview because it appears not be working. For most Summary documents, I get the following error message:

"CDRPreview web service error: The 'xmlns:cdr' attribute is not declared.Validation error occurred when validating the instance document.,2404,82"

I didn't have problems with protocol documents and the error appears not to be specific do the style attribute. Also pub preview works fine on Bach.

Comment entered 2011-04-07 15:40:49 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-04-07 15:40:49
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

(In reply to comment #2)
> Verified on Mahler. I tested with QC reports and they all worked fine.
> However, I was unable to test with pub preview because it appears not be
> working.

As I mentioned at the status meeting, this was likely related to a problem in a summary filter that was recently modified. I've checked the PP report on MAHLER and the report ran OK.

Could you please check again?

Comment entered 2011-04-08 15:44:16 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-04-08 15:44:16
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::4

(In reply to comment #3)
> (In reply to comment #2)
> > Verified on Mahler. I tested with QC reports and they all worked fine.
> > However, I was unable to test with pub preview because it appears not be
> > working.
>
> As I mentioned at the status meeting, this was likely related to a problem in a
> summary filter that was recently modified. I've checked the PP report on
> MAHLER and the report ran OK.
>
> Could you please check again?

Verified. Please promote to Bach.

Comment entered 2011-04-08 19:26:27 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-04-08 19:26:27
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

The following CSS and template files have been copied to MAHLER and BACH:
Procedure.xml - R10061
PatientSummary.xml - R10061
OutOfScopeProtocol.ctm - R10062
Summary.ctm - R10062
Citation.ctm - R10062
GlossaryTermConcept.ctm - R10062
Documentation.ctm - R10062
Media.ctm - R10062
PatientSummary.ctm - R10062
MiscellaneousDocument.ctm - R10062
DocumentationToC.ctm - R10062

Please verify on BACH (but don't close the issue since I wasn't able to copy the files to FRANCK yet).

Comment entered 2011-04-11 11:30:35 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-04-11 11:30:35
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::6

(In reply to comment #5)
> Please verify on BACH (but don't close the issue since I wasn't able to copy
> the files to FRANCK yet).

verified on Bach.

Comment entered 2011-04-11 17:32:52 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-04-11 17:32:52
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

I've copied the files to FRANCK.
Closing issue.

Elapsed: 0:00:00.001455