CDR Tickets

Issue Number 3303
Summary [Glossary] Non Publishable Also Calls in the dictionary
Created 2011-02-02 12:54:46
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2011-03-02 14:37:30
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107631
Description

BZISSUE::4995
BZDATETIME::2011-02-02 12:54:46
BZCREATOR::William Osei-Poku
BZASSIGNEE::Volker Englisch
BZQACONTACT::William Osei-Poku

I am not sure if you are aware of this already or whether it was discussed in the past. When there is an existing GTC (with an existing GTN that has already been published to cancer.gov) and we create a new term name (also called) with a link to the GTC, the existing GTN publishes with the new also called even though the new term name has not been made publishable.

The problem with this is that if a dictionary user wanted to search for the also called term name, it would not be in the dictionary as its own entry because it has not been published as its own entry in the dictionary.

The other problem with this is that, a term name that has a status of new pending or even rejected but has not been approved or blocked could potentially end up on cancer.gov as an also called.

It looks like as long as there is a link to the concept in a term name, it is picked in the dictionary as an also called if there is an existing (published) term name that uses the same concept document.

Could you please look into this or perhaps clarify this if we are missing something? However, if what we've described above is accurate, we propose that you make changes to the publication filters so that an also called would not be picked up if it has not been made publishable by a user. We could decide to change our process to not link concepts to new glossary term names until they are ready to be published but that would be a significant change in our process and would create a lot of problems during the QC process, among other things.

Here are two examples we identified:
CDR0000689578 - imaging test is a new term name that has a “New pending” status
CDR0000045720 - imaging procedure is an existing term name that is currently in the dictionary
Here is the link
http://www.cancer.gov/dictionary/?CdrID=45720
It shows imaging test as an also called even though that has not been published yet. It looks like it would be better to not show the also called in the dictionary until the term name is made publishable.
Another example is Vitamin E with alpha-tocopherol as the also called.
http://www.cancer.gov/dictionary/?CdrID=45023

Comment entered 2011-02-02 16:33:10 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-02 16:33:10
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

Your description is basically correct except. When creating the glossary definition the filter checks if another GTN exists with the same GTC and adds the 'Also-called' text to the definition based on the result. However, a blocked document would not be added as an 'Also-called'.

The SQL query that's submitted from within the filter looks in the query_term table (meaning that a publishable version doesn't need to exist) and it doesn't check the status of the GTN document.

We may want to discuss at our meeting which of the two restrictions would best fit our needs.

Comment entered 2011-02-09 14:43:07 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-09 14:43:07
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2

It has been decided to check the status for the decision if the 'Also called' should be added.

As soon as MAHLER is available again I'll make this change.

Comment entered 2011-02-21 16:58:10 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-21 16:58:10
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3

I've updated the filter on FRANCK to only include "Also-called" terms if their status is 'Approved' or 'Revision pending'.
CDR616048.xml: Vendor Filter: GlossaryTermName - R10034

This is ready for review on FRANCK.

Comment entered 2011-02-22 12:35:27 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-02-22 12:35:27
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::4

(In reply to comment #3)
> I've updated the filter on FRANCK to only include "Also-called" terms if their
> status is 'Approved' or 'Revision pending'.
> CDR616048.xml: Vendor Filter: GlossaryTermName - R10034
>
> This is ready for review on FRANCK.

Verified on Franck. Seems to be working fine. Would you run a diff?

Comment entered 2011-02-22 19:51:03 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-22 19:51:03
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5

The filter change resulted in changes to 28 document on FRANCK.
Please see attached diff file.

Comment entered 2011-02-22 19:51:03 by Englisch, Volker (NIH/NCI) [C]

Attachment AlsoCalled.txt has been added with description: Diff Report for "Also Called" Filter Change.

Comment entered 2011-02-23 15:55:17 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-02-23 15:55:17
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::6

(In reply to comment #5)
> Created attachment 2086 [details]
> Diff Report for "Also Called" Filter Change.
>
> The filter change resulted in changes to 28 document on FRANCK.
> Please see attached diff file.

I looked at several terms in the file and they all seem okay to me. I think in this case we don't have to do anything, right? It looks like for the most part, the report is identifying terms that will be dropped from the also called because they no longer qualify. If this is accurate, please promote to Bach.

Comment entered 2011-02-25 17:30:21 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-25 17:30:21
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

The following filter has been copied to BACH:
CDR616048.xml: Vendor Filter: GlossaryTermName - R10034

I will monitor tonight's publishing job and when everything runs OK we can close this issue on Monday.

Comment entered 2011-02-28 13:36:12 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-28 13:36:12
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

(In reply to comment #7)
> I will monitor tonight's publishing job and when everything runs OK we can
> close this issue on Monday.

I made a mistake on Friday causing almost all of the GlossaryTerm documents on Cancer.gov to be updated with ugly data.
While running the diff report I identified a problem with my modified SQL query which I fixed on FRANCK but I forgot to version it in SVN. When I updated the filter on BACH I was using the older version of the SQL script instead of the newer, corrected version. This caused all GlossaryTerms on Cancer.gov with an 'Also-called' text to display the also-called term twice.

I have fixed the problem on BACH but I believe we should run a hot-fix for the GlossaryTerms to fix this before Friday.

Comment entered 2011-02-28 14:40:46 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-28 14:40:46
BZCOMMENTOR::Volker Englisch
BZCOMMENT::9

I ran a GlossaryTerm export job to fix the problem on Cancer.gov.

All GlossaryTerms are again displaying correctly.

Please verify on Cancer.gov/Bach and close this bug.

Comment entered 2011-03-02 14:37:30 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2011-03-02 14:37:30
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::10

(In reply to comment #9)
> I ran a GlossaryTerm export job to fix the problem on Cancer.gov.
>
> All GlossaryTerms are again displaying correctly.
>
> Please verify on Cancer.gov/Bach and close this bug.

Verified. They look good. Thanks!
Closing issue.

Attachments
File Name Posted User
AlsoCalled.txt 2011-02-22 19:51:03 Englisch, Volker (NIH/NCI) [C]

Elapsed: 0:00:00.001809