CDR Tickets

BZDATETIME::2010-05-24 10:33:50
BZCOMMENTOR::Kim Eckley
BZCOMMENT::1

Attachment added.

Attachment Global_Foreign Trials.xlsx has been added with description: List of trials to potentially have value added

BZDATETIME::2010-05-24 14:31:41
BZCOMMENTOR::Alan Meyer
BZCOMMENT::2

I just did a check to see if there are any Organizations that
have a location in the U.S. and also one that's not in the U.S.
There weren't any (something Lakshmi was able to tell me even
without checking.) So I will write the global change to perform
the domestic site check by simply checking if there is a U.S.A.
location for an Organization linked to one of the trials. If
there is, I will not add the new ContactResponse value to the
protocol, without bothering to check any Organization location
link fragment IDs for those Orgs that have multiple locations.

Unless someone thinks otherwise, I will only add the new
ContactResponse to documents that do not currently have a
ContactResponse. This is what we did in the global change
written to add "Transfer not required" values (OCECDR-3045).

That will exclude any docs that, for example, were modified to
add a ContactResponse after Kim compiled the spreadsheet. It
will also enable us to run the change again if we ever need to
add additional trials to the list without causing any problems
for documents already modified.

BZDATETIME::2010-05-24 16:20:38
BZCOMMENTOR::Alan Meyer
BZCOMMENT::3

Also in accord with our handling of "Transfer not required"
trials, I plan to do the following:

Abort processing if this element exists:
'/InScopeProtocol/CTGovOwnershipTransferInfo/CTGovOwnerOrganization'
That's in addition to the 'CTGovOwnershipTransferContactResponse'
element check.

Add a 'Date' element with the current date as a sibling
element to the new 'CTGovOwnershipTransferContactResponse'
element.

Only modify the current working document. I will leave the
last version and last publishable version alone.

I do not plan to add a Comment element. We needed that in the
"Transfer not required" global change because there were five
different reasons why a protocol could be selected for the
global. However there is only one reason for selecting a
document in this global and it's fully explained in the string
"Foreign Trial - No Domestic Site".

For each document in Kim's spreadsheet, I'll either transform the
document as requested and log the transformation, or else log the
reason why the transformation was not made, i.e.:

Contact information was already found in the document.

At least one U.S. site was found. I'll log the doc ID of the
site but, if I find one, won't bother to check any of the
others unless someone wants me to log all of the U.S. sites I
find in the protocol.

Since all of the above is consistent with what we've done in the
past, I'll assume it's okay and proceed with that plan. If it's
wrong, let me know before we run in live mode and I'll change it.

BZDATETIME::2010-05-25 08:59:28
BZCOMMENTOR::Kim Eckley
BZCOMMENT::4

(In reply to comment #2)

> Unless someone thinks otherwise, I will only add the new
> ContactResponse to documents that do not currently have a
> ContactResponse. This is what we did in the global change
> written to add "Transfer not required" values (OCECDR-3045).
> That will exclude any docs that, for example, were modified to
> add a ContactResponse after Kim compiled the spreadsheet. It
> will also enable us to run the change again if we ever need to
> add additional trials to the list without causing any problems
> for documents already modified.

Yes - this makes sense!

BZDATETIME::2010-05-25 09:06:29
BZCOMMENTOR::Kim Eckley
BZCOMMENT::5

(In reply to comment #3)
> Also in accord with our handling of "Transfer not required"
> trials, I plan to do the following:
> Abort processing if this element exists:
> '/InScopeProtocol/CTGovOwnershipTransferInfo/CTGovOwnerOrganization'
> That's in addition to the 'CTGovOwnershipTransferContactResponse'
> element check.
> Add a 'Date' element with the current date as a sibling
> element to the new 'CTGovOwnershipTransferContactResponse'
> element.
> Only modify the current working document. I will leave the
> last version and last publishable version alone.
> I do not plan to add a Comment element. We needed that in the
> "Transfer not required" global change because there were five
> different reasons why a protocol could be selected for the
> global. However there is only one reason for selecting a
> document in this global and it's fully explained in the string
> "Foreign Trial - No Domestic Site".
> For each document in Kim's spreadsheet, I'll either transform the
> document as requested and log the transformation, or else log the
> reason why the transformation was not made, i.e.:
> Contact information was already found in the document.
> At least one U.S. site was found. I'll log the doc ID of the
> site but, if I find one, won't bother to check any of the
> others unless someone wants me to log all of the U.S. sites I
> find in the protocol.
> Since all of the above is consistent with what we've done in the
> past, I'll assume it's okay and proceed with that plan. If it's
> wrong, let me know before we run in live mode and I'll change it.

Thanks for filling in the gaps. Everything sounds just fine! Now we just need the value in OCECDR-3163.

BZDATETIME::2010-05-25 11:37:30
BZCOMMENTOR::Alan Meyer
BZCOMMENT::6

(In reply to comment #5)

> Thanks for filling in the gaps. Everything sounds just fine! Now we just need
> the value in OCECDR-3163.

I think I'm ready to go. I've tested with a sample of the records
to be transformed and a sample of the records that shouldn't be
transformed. When 4850 is done I'll run in test mode on Mahler.

BZDATETIME::2010-05-25 11:38:57
BZCOMMENTOR::Kim Eckley
BZCOMMENT::7

(In reply to comment #6)

> I think I'm ready to go. I've tested with a sample of the records
> to be transformed and a sample of the records that shouldn't be
> transformed. When 4850 is done I'll run in test mode on Mahler.

4850 is verified in Mahler if you wanted to give it a go.

BZDATETIME::2010-05-25 11:55:52
BZCOMMENTOR::Alan Meyer
BZCOMMENT::8

(In reply to comment #7)

> 4850 is verified in Mahler if you wanted to give it a go.

I'll run this afternoon. Bob is going to look at a character
set issue regarding the hyphen in the new value. We probably
want to use a plain ASCII hyphen instead of the extended
character that's in there now.

BZDATETIME::2010-05-25 15:01:45
BZCOMMENTOR::Alan Meyer
BZCOMMENT::9

The test completed with no real errors. Test results are
available at:

http://mahler.nci.nih.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2010-05-25_14-19-01

The log file is attached. The file shows two errors at the end
with the misleading message: "...Cannot find document type..."
Those two docs exist on Bach but aren't on Mahler. What really
can't be found is the documents themselves, but the CDR server
looks first for a document type, produces that message, and quits
before it understands the real problem.

There were no docs found with U.S. sites or with existing transfer
information.

Attachment Request4851.log has been added with description: Log file from test run on Mahler

BZDATETIME::2010-05-26 11:01:06
BZCOMMENTOR::Kim Eckley
BZCOMMENT::10

(In reply to comment #9)
> Created attachment 1933 [details]
> Log file from test run on Mahler
> The test completed with no real errors. Test results are
> available at:
> http://mahler.nci.nih.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2010-05-25_14-19-01

Looks good! Ready for BACH when BACH is ready with the new value.

BZDATETIME::2010-05-27 10:47:02
BZCOMMENTOR::Alan Meyer
BZCOMMENT::11

I ran a test on Bach with just two records. There was no
validation error, so the new value appears to be working
fine on Bach.

I usually do these big global changes in the evening, after
work has finished and after nightly publishing, so that they
won't slow down any other uses of the server or cause or run
into any locking problems.

I'll plan to run in test mode tonight. If all goes well, I'll
run in live mode over the weekend.

Alternatively, if the test on Mahler was sufficient (the
databases are almost the same for purposes of this global
change), I can run in live mode tonight.

Unless I hear otherwise, that will be my plan - test mode on
Bach tonight. If approved, live mode this weekend.

BZDATETIME::2010-05-27 22:47:11
BZCOMMENTOR::Alan Meyer
BZCOMMENT::12

The test mode run on Bach is complete. I also ran 20 records in
live mode on Mahler just to be sure that nothing funky happens in
live mode that didn't show up in the test.

Both runs looked fine to me.

I have not attached any log files since there were no errors, no
warnings, and no locked documents. The log file has nothing in
it that needs review.

The test results on Bach are equally boring. The changes for all
the documents are identical. They can be seen at:

http://bach.nci.nih.gov/cgi-bin/cdr/ShowGlobalChangeTestResults.py?dir=2010-05-27_21-27-20

The full test mode run took about 25 minutes on Bach. It will
take longer in live mode because it has to save the documents, so
we probably want to run in non-prime time again.

I can do that this weekend if desired, or wait until next week.

I may also be running a database archive migration program (see
OCECDR-2949) this weekend. If so, and if it is desirable for me to
run the global this weekend, I'll run the migration first, then
run the global.

In the last comment I proposed to run in live mode this weekend
but I won't do that until someone directs me to do it. Someone
let me know if I should run this weekend.

BZDATETIME::2010-05-28 08:33:05
BZCOMMENTOR::Kim Eckley
BZCOMMENT::13

(In reply to comment #12)
> The test mode run on Bach is complete.
> The test results on Bach are equally boring.

Ha.

> I can do that this weekend if desired, or wait until next week.
> In the last comment I proposed to run in live mode this weekend
> but I won't do that until someone directs me to do it. Someone
> let me know if I should run this weekend.

Enjoy the weekend - running next week is fine with me.

BZDATETIME::2010-06-10 10:31:56
BZCOMMENTOR::Alan Meyer
BZCOMMENT::14

I had planned to run this in live mode on Bach last week but forgot. Unless I hear an objection, I'll run it tonight after usage of the system has quieted down.

BZDATETIME::2010-06-10 23:39:24
BZCOMMENTOR::Alan Meyer
BZCOMMENT::15

I'm running this global in live mode on Bach. I will be going
home before it completes, but I'll report on the results tomorrow
or Saturday.

BZDATETIME::2010-06-11 00:43:16
BZCOMMENTOR::Alan Meyer
BZCOMMENT::16

The live run is complete. There were a fair number of
validation warnings - probably to be expected.

The log file is attached.

Attachment Request4851.log has been added with description: Log file from live run on Bach

BZDATETIME::2010-06-11 00:43:47
BZCOMMENTOR::Alan Meyer
BZCOMMENT::17

Marking this resolved-fixed.

BZDATETIME::2010-06-17 14:09:51
BZCOMMENTOR::Kim Eckley
BZCOMMENT::18

(In reply to comment #17)
> Marking this resolved-fixed.

Verified.
Closing issue.