Issue Number | 2832 |
---|---|
Summary | Collection of Cancer.gov/Gatekeeper Issues |
Created | 2009-02-27 16:09:56 |
Issue Type | Improvement |
Submitted By | Englisch, Volker (NIH/NCI) [C] |
Assigned To | Englisch, Volker (NIH/NCI) [C] |
Status | Closed |
Resolved | 2013-12-23 18:21:37 |
Resolution | Fixed |
Path | /home/bkline/backups/jira/ocecdr/issue.107160 |
BZISSUE::4507
BZDATETIME::2009-02-27 16:09:56
BZCREATOR::Volker Englisch
BZASSIGNEE::Volker Englisch
BZQACONTACT::Lakshmi Grama
We want to collect issues to be brought up with Cancer.gov folks that we encountered recently.
BZDATETIME::2009-02-27 16:19:11
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1
Issue #1: Handling of table borders.
It appears that the "Frame" attribute of the "Table" element is not
handled correctly. The attribute
Frame=None
should display a table without outside borders like this
Cell1 | Cell2
----------------
Cell3 | Cell4
but the table is displayed without frame and without column/row separater like this
Cell1 Cell2
Cell3 Cell4
On the flip side, it should be possible to display a table with just
the outside border when setting
Frame=All
like the following
------------------
| Cell1 Cell2 |
| |
| Cell3 Cell4 |
------------------
but in this case the outside frame as well as the inside lines are displayed.
BZDATETIME::2009-02-27 16:22:12
BZCOMMENTOR::Volker Englisch
BZCOMMENT::2
Issue #2: Handling of alignment and column width within table cells
The handling of the Align attribute and specified column width is not handled as expected.
BZDATETIME::2009-02-27 16:25:43
BZCOMMENTOR::Volker Englisch
BZCOMMENT::3
Issue #3: Markup within image captions
Markup within image captions is not always recognized. For instance, the <strong> element displays text in bold but the <emphasis> tag doesn't display text in italics. Also, elements like <subscript> and <superscript> are ignored.
In addition, when trying to display an image using the 'Enlarge' link the user receives an error message if markup had been included in the captions.
BZDATETIME::2009-03-05 15:23:59
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::4
Issue #4: Implement new Dictionary data elements, including
NCIThesaurusID to create a link to the NCIT record and
<element name="RelatedExternalRef"
type="RelatedExternalRef"/>
<element name="RelatedSummaryRef" type="RelatedSummaryRef"/>
<element name="RelatedDrugSummaryRef"
type="DrugSummaryRef"/>
Note: We are changing RelatedDrugSummaryRef to
RelatedDrugSummaryLink.
BZDATETIME::2009-03-09 15:39:00
BZCOMMENTOR::Volker Englisch
BZCOMMENT::5
Issue #5: Fact Sheet Documents
Fact Sheets would probably be included in the CDR as a new document
type.
Gatekeeper/Cancer.gov would need to be able to handle this new document
type.
BZDATETIME::2009-03-26 08:12:20
BZCOMMENTOR::Lakshmi Grama
BZCOMMENT::6
New data elements for CTGOV Protocols
BZDATETIME::2009-03-26 08:13:11
BZCOMMENTOR::Lakshmi Grama
BZCOMMENT::7
Met with Cancer.gov team. Jay is working on Table issues. We need to provide information to Cancer.gov on new data elements for CTGOV protocols
BZDATETIME::2009-03-26 13:54:31
BZCOMMENTOR::Bob Kline
BZCOMMENT::8
Bumped up at status meeting.
BZDATETIME::2009-04-03 15:21:18
BZCOMMENTOR::Volker Englisch
BZCOMMENT::9
Jay found old documentation regarding the table rendering which he forwarded.
Attachment Tables.htm has been added with description: Email from Jay He regarding table rendering
BZDATETIME::2009-04-03 15:24:04
BZCOMMENTOR::Volker Englisch
BZCOMMENT::10
My response to Jay on how to render tables
-----------------------------------------------------------------------
From: Englisch, Volker (NIH/NCI) [C]
Sent: Friday, April 03, 2009 1:44 PM
To: He, Jianxiao (NIH/NCI) [C]; Rosenbaum, Olga (NIH/NCI) [C]; Pizzillo,
Bryan (NIH/NCI) [C]
Cc: Grama, Lakshmi (NIH/NCI) [E]; Beckwith, Margaret (NIH/NCI) [E];
Kline, Robert (NCI); 'Alan Meyer'
Subject: RE: tables in Drug Info Summaries
Jay,
I've spend some more time looking at the display of tables in HTML
and compared it between three different browsers - IE7, FireFox 3, and
Chrome, respectively. Based on this I can tell you with certainty that
I'm unable to give you the HTML table attributes that need to be set
(setting the frame, border, rules attribute of the table element)
because the output depends largely on the browser and the CSS that's
being used.
For instance, in FireFox using the CSS
table { border-collapse: collapse; }
changes the way the cell borders are displayed depending on the setting
of the border attribute for the Table element and using the CSS
table { border-width: N; }
changes the way the table frame is displayed in FireFox depending on the
frame attribute and the border attribute and also, the frame attribute
changes the cell border display in IE7.
Having said that, there is an immediate need in terms of the proper
framing/bordering of tables and table cells and it appears that all
browsers that I have tested agree on this one, namely to display a table
without any borders and without a frame. The setting for such a table
would be
<table frame="void" border="0">...</table>
or
<table>...</table>
The first version would be preferred in order to avoid having the
frame/border display set via CSS.
The second immediate need for the table display is to being able and
specify the table width in a way as displayed in the sample document: A
very small first column followed by a wide column (for a
definition).
According to Bob this is not a simple task to implement in general but I
would suggest, if everyone agrees, to implement something allowing to
specify the table width of the first (or first few) column with an
absolute measure therefore allowing a table layout like the
following:
--------------------------------------------------------
| V | = Volker |
--------------------------------------------------------
| E | = Englisch |
--------------------------------------------------------
Along with this goes the third immediate need for the table display
which is the ability to align text.
This is currently only possible if the default column size hasn't been
modified. Please see the sample I had created where the text of the
second table in the first column should be right aligned.
Everything else that isn't working currently should eventually be
addressed but may need further discussions.
We might even want to discuss at some other time if all of the options
available in the CDR can or should be supported given the fact that the
browser display is still unreliable for certain elements.
–
Volker Englisch
Contractor - Lockheed Martin
phone: (301) 496-0102 (CTB)
mailto:volker@mail.nih.gov
BZDATETIME::2009-04-03 15:51:38
BZCOMMENTOR::Volker Englisch
BZCOMMENT::11
Test file to be viewed in different browers.
Attachment test_noCSS.html has been added with description: Test file for Table Frame/Border Display (no CSS)
BZDATETIME::2009-04-03 15:55:25
BZCOMMENTOR::Volker Englisch
BZCOMMENT::12
The last file included a rules attribute which is now removed.
Attachment test_noCSS.html has been added with description: Test file for Table Frame/Border Display (no CSS)
BZDATETIME::2009-04-03 15:56:56
BZCOMMENTOR::Volker Englisch
BZCOMMENT::13
Attachment test_collapse.html has been added with description: Test file for Table Frame/Border Display (collapse borders)
BZDATETIME::2009-04-03 15:57:49
BZCOMMENTOR::Volker Englisch
BZCOMMENT::14
Attachment test_border.html has been added with description: Test file for Table Frame/Border Display (CSS borders)
BZDATETIME::2009-04-07 16:59:50
BZCOMMENTOR::Volker Englisch
BZCOMMENT::15
I had a meeting with Olga and Jay to discuss the problems with the
table display. It appears that we're facing problems due to coding and
due to browser display bugs. We also discussed the immediate need for
the DIS documents.
1) We need to be able to display a table without border:
This does work in all browsers that I tested (IE7, FF3, Chrome) by
setting
frame=Void and border=0
but since since Cancer.gov also sets
rules=all
the grid lines are being displayed in FireFox
2) We need to be able to right-align the cell content:
This does not work if we're setting the
align=right/center
attribute for a column but it does work if the attribute is set for
an
individual cell.
3) We need to be able to set the column width:
The Cancer.gov conversion does not handle the notation
width=N*
properly. The only thing that seems to work properly would be to
specify
the column width in percentages. However, this would require a
schema
change at our end and would not be in compliance with the CALS table
format.
BZDATETIME::2009-04-20 11:55:19
BZCOMMENTOR::Volker Englisch
BZCOMMENT::16
I talked to Jay last week and he said he will try to fix item (1) listed in comment #15.
BZDATETIME::2009-05-11 15:00:58
BZCOMMENTOR::Volker Englisch
BZCOMMENT::17
A) Section headings following an itemized list are missing a blank
line
between the list and the heading:
Example (please see Breast Cancer Treatment, HP - section "AJCC
Stage
Groupings"):
This is a list Title
List item one
List item two
List item three
Heading of following Section
Paragraph of section...
B) Compact Lists within non-compact lists are producing excessive
white space
after the compact lists.
Example (please see Breast Cancer Treatment, HP - section "Cytotoxic
chemotherapy"):
First item non-compact list
First item compact list
Second item compact list
Second item non-compact list
First item compact list
There should only be one blank line between list items of non-compact lists.
BZDATETIME::2009-05-11 15:13:48
BZCOMMENTOR::Volker Englisch
BZCOMMENT::18
In publish preview for DrugInfoSummaries, Tables are enclosed in
anchor tags causing the table heading to be displayed as a link in
FireFox (IE ignores this).
The table title is therefore displayed in red and underlined instead of
black.
BZDATETIME::2009-05-20 13:10:50
BZCOMMENTOR::Volker Englisch
BZCOMMENT::19
I've send an email to Cancer.gov folks identifying the issues that should get modified before the Drug Combination Summaries can get published:
------------------------------------
From: Englisch, Volker (NIH/NCI) [C]
Sent: Tuesday, May 19, 2009 6:42 PM
To: He, Jianxiao (NIH/NCI) [C]; Rosenbaum, Olga (NIH/NCI) [C]
Cc: Beckwith, Margaret (NIH/NCI) [E]; Grama, Lakshmi (NIH/NCI) [E];
Price, Deborah (NIH/NCI) [E]
Subject: Drug Combination Summaries
Jay/Olga,
In order for our new Drug Combination summaries to go live there are
a few display items that OCCM would need to get fixed and I'm hoping
that these are not too difficult to be implemented. (We had already
talked about some of these earlier.)
As a sample document please see the following published version on
GatekeeperGK
http://previewgk.cancer.gov/cancertopics/druginfo/abvd
I am also attaching the HTML code for this summary including my proposed
changes.
Problem #1 - Table Gridlines:
When specifying to display a table without a frame, the 'Frame'
attribute for the table element is set to
Frame="void"
This will automatically suppress the frame as well as the gridlines.
However, since Cancer.gov specifically sets the table attribute
Rules="all"
FireFox is displaying the gridlines.
Proposed Solution:
Do not set the Rules="all" attribute when the Frame attribute is set to
Frame="void"
Problem #2 - Table Heading Display:
In Firefox the table header is displayed in a different color than other
headings. It is displayed as a link (also displayes underlined when
hovering over it) because the table is wrapped within an anchor
element.
Proposed Solution:
Instead of enclosing the table in the anchor element move the closing
anchor up before the table starts by changing the code
<TableSectionXML>
<a name="SectionXML_N">
<table>
…
</table>
<a name="END_TableSection"></a>
</a>
</TableSectionXML>
to
<TableSectionXML>
<a name="SectionXML_N"></a>
<table>
…
</table>
<a name="END_TableSection"></a>
</TableSectionXML>
Problem #3 - Vertical Spacing following a table:
It appears that the vertical spacing between a table and a paragraph (or
an itemized list and a paragraph) should be reduced. This spacing
problem is a result of the use of the <br></br> elements at
the end of a table therefore always adding an extra
blank line regardless if it's needed or not.
Proposed Solution:
Replace the <br></br> element directly following the
</table> element with the <p></p> element.
This would ensure sufficient white space after a table (i.e. if another
table is following) but not add to the already existing white space if a
paragraph is following the table.
Problem #4 - Vertical Spacing prior to Drug Combination Table:
The drug combination table is directly following the table listing the
'FDA Approved' text without vertical white space.
Proposed Solution:
Same as above, or if that's not possible one could modify the Drug
Combination table by adding a Para element to the top by changing the
following output
<TableSectionXML>
<a name="SectionXML_N">
<table>
…
to
<TableSectionXML><p></p>
<a name="SectionXML_N">
<table>
…
We are hoping that at least the two first items could get implemented before the first Drug Combination Summary goes live.
Please let me know if you need any additional information.
BZDATETIME::2009-05-20 13:12:16
BZCOMMENTOR::Volker Englisch
BZCOMMENT::20
Attachment DrugCombo2.html has been added with description: DrugInfo Summary as attached to email
BZDATETIME::2009-05-27 12:38:34
BZCOMMENTOR::Volker Englisch
BZCOMMENT::21
Jay has already fixed issues #1 and #4. He is still working on issue #3 and #4.
BZDATETIME::2009-06-04 14:00:18
BZCOMMENTOR::Volker Englisch
BZCOMMENT::22
Jay has fixed those issues we had asked to be resolved before
publishing the DrugCombination summaries. I had a meeting with Olga, Jay
and the testing team to discuss the scope of the tests.
The testing team is working on one CG release right now and will start
testing Jay's changes afterward. In the meantime I will prepare and
publish a few of the new DrugCombination summaries and all summaries
containing tables.
BZDATETIME::2009-06-12 14:30:40
BZCOMMENTOR::Volker Englisch
BZCOMMENT::23
Testing of the DrugCombination Summaries will start on Monday.
We are waiting for the software changes to be moved to the QA
environment before the test data can be loaded.
BZDATETIME::2009-06-30 13:36:08
BZCOMMENTOR::Volker Englisch
BZCOMMENT::24
Testing for the table changes is complete but we have requested one
more item:
The text for linked text is displayed in a larger font than the regular
text.
Jay has fixed this to make all text small and is not researching if it's
possible to make all text larger without effecting the text in other
tables displayed in summaries.
BZDATETIME::2009-07-02 13:26:22
BZCOMMENTOR::Volker Englisch
BZCOMMENT::25
(In reply to comment #24)
> Jay has fixed this to make all text small and is not
researching
Correction:
This should actually read
"Jay has fixed this to make all text small and is now
researching ..."
BZDATETIME::2009-07-24 16:35:34
BZCOMMENTOR::Volker Englisch
BZCOMMENT::26
The users decided to request another font change. The font within the DrugCombination table should be displayed with the same font size as the text outside of the table.
I need to discuss with Reza, Blair and Jay if and when this could get done.
BZDATETIME::2009-08-07 11:29:33
BZCOMMENTOR::Volker Englisch
BZCOMMENT::27
Issue #6: Characters are dropped in image captions
We already know from issue #3 (Comment #3) that markup is ignored in captions and trying to enlarge an image containing markup like <superscript>, <strong>, etc. will cause an error message.
However, CIAT reported that for a caption listing the text 'stage IIIE+S' for the glossary term name "stage III childhood Hodgkin lymphoma" (CDR430898) the '+'-sign is being replaced by a space in the pop-up display of the image.
Sample:
http://previewqa.cancer.gov/templates/db_alpha.aspx?CdrID=430898
Click on the image and scroll down to the caption. The last sentence
starting with
In stage IIIS E, cancer is found in lymph node groups
should read instead
In stage IIIS+E, cancer is found in lymph node groups
^^^^^^^
BZDATETIME::2009-08-19 11:12:33
BZCOMMENTOR::Volker Englisch
BZCOMMENT::28
The issues related to the Drug Combination Summaries (except for the font size of the text within the table) have been fixed and are now in production. I am therefore dropping the priority again for this issue.
BZDATETIME::2009-10-07 12:31:07
BZCOMMENTOR::Volker Englisch
BZCOMMENT::29
Per discussion here is a summary of the outstanding issues. It has been decided to lower the priority of this issue for now since the most urgent issues related to the publishing of the Drug Combination Summaries have been resolved.
[ ] Issue 1 - Handling of table borders (Comment #1)
[X] a - Allow table to be displayed without grid and frame
[ ] b - Allow table to be displayed with just grid or just frame
(not certain if there might be a need for this)
[ ] Issue 2 - Handling of alignment within table cells
[ ] a - right/left alignment for individual cell OK but not
alignment on character. (Comment #15)
[ ] b - alignment for column not working
[ ] Issue 3 - Handling of column width (Comment #15)
It is currently not possible to adjust the column width with our
format. We could use percentages to specify column width but
that's not allowed by the DTD.
[ ] Issue 3 - Markup within image captions (Comment #3)
[ ] a - Bold, italics, superscript, etc. not working in captions
[ ] b - Characters are dropped in image captions (Comment #27)
[ ] Issue 4 - Implement new Dictionary data elements (Comment #4)
[ ] Issue 5 - Fact Sheet Documents (Comment #5)
[ ] Issue 6 - New data elements for CTGOV Protocols (Comment #6)
BZDATETIME::2009-10-07 12:35:20
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::30
Would rendering a 3/4 size image go on this list as well? I had put in another issue to add that size to the schema, but it seems like cancer.gov would have to do something as well.
BZDATETIME::2009-11-04 18:05:07
BZCOMMENTOR::Volker Englisch
BZCOMMENT::31
(per discussion at last week's status meeting)
We've discussed that the Gatekeeper processing fails removing documents from Cancer.gov if redirection links are pointing to a document to be removed and we generally agree that the existence of a redirection link should not prevent a document from being removed from Cancer.gov.
BZDATETIME::2010-02-02 14:54:41
BZCOMMENTOR::Margaret Beckwith
BZCOMMENT::32
Display of the HP dictionary terms on Cancer.gov.:
1. In the pop-up boxes that a user gets when they click on a glossary
term in the HP
Genetics summaries, the terms are shown with the pronunciations if they
have one. The
only reason a few of the terms have a pronunciation is that they also
have a patient
definition and appear in the Dictionary of Cancer Terms. Would there be
any way of
suppressing the pronunciations for the HP terms?
2. Similar question about the images. The media link is actually in the
patient
definition block, but is showing in the HP term pop-up on Cancer.gov.
This is fine but
Robin was wondering why it was showing up?
3. I know this is a Cancer.gov question, but we were wondering if there
was any way to
publish the stand-alone Genetics Dictionary from the CDR? Right now it
is maintained
completely manually.
BZDATETIME::2010-05-11 10:53:48
BZCOMMENTOR::Volker Englisch
BZCOMMENT::33
(In reply to comment #30)
> Would rendering a 3/4 size image go on this list as well? I had put
in another
> issue to add that size to the schema, but it seems like cancer.gov
would have
> to do something as well.
This change will be promoted to Cancer.gov on Wednesday.
BZDATETIME::2010-08-12 15:32:26
BZCOMMENTOR::Volker Englisch
BZCOMMENT::34
Victoria had a problem with a table in the Breast Cancer Summary
which got fixed.
While we discussed the table layout it was mentioned that a table footer
isn't always displayed in the same format. If a table has a single row
footer, the footer is displayed within the table. However, if the table
has a multi-row footer it is not:
Table 1: Single row footer
--------------------------------------------
Column Header 1 |
Column Header 2 |
--------------------------------------------
Cell 1 |
Cell 2 |
--------------------------------------------
Cell 3 |
Cell 4 |
--------------------------------------------
Single row table footer |
--------------------------------------------
Table 2: Multi-row Table footer
--------------------------------------------
Column Header 1 |
Column Header 2 |
--------------------------------------------
Cell 1 |
Cell 2 |
--------------------------------------------
Cell 3 |
Cell 4 |
--------------------------------------------
first row table footer
second row table footer
As a caveat, the first row being displayed within the table is only true if the footer row cells are being merged.
Table 3: Single row, footer for each column
--------------------------------------------
Column Header 1 |
Column Header 2 |
--------------------------------------------
Cell 1 |
Cell 2 |
--------------------------------------------
Cell 3 |
Cell 4 |
--------------------------------------------
Column 1 footer Column 2 Footer
These rules had been provided in the past by Jay (see Comment #9)
Another issue, namely the inability to specify the column width for the resulting HTML tables had also been discussed as part of this issue.
At some point in the future we may want to revisit how tables are being created/stored in the CDR and how they are rendered on Cancer.gov.
BZDATETIME::2010-09-01 12:40:44
BZCOMMENTOR::Volker Englisch
BZCOMMENT::35
In comment 17 I had already mentioned a display issue of the PDQ
documents on Cancer.gov. These were
a) Section headings following an itemized list are missing a blank
line
between the list and the heading
b) Compact Lists within non-compact lists are producing excessive white
space
after the compact lists.
The second of these two items had been corrected along with the changes for the DrugCombination table.
The first issue is still valid and I'd like to add two more items here because they also involves vertical spacing within the document and are cause by improper use of the <br> tag:
1) For main SummarySection elements there is excessive white space
between
the SectionTitle and the following text if that text is the title of
a
sub-SummarySection. If a Para element follows immediately after
the
SummarySection the spacing if OK.
Example (Breast Cancer Treatment - HP):
http://www.cancer.gov/cancertopics/pdq/treatment/breast/healthprofessional/allpages#Section_85
LOBULAR CARCINOMA IN SITU
INTRODUCTION
The term lobular carcinoma <Emphasis>in situ</Emphasis>
(LCIS) is
misleading. This lesion is more appropriately termed lobular
neoplasia.
Two extra blank lines are inserted after the title. The output should look like this instead:
LOBULAR CARCINOMA IN SITU
INTRODUCTION
The term lobular carcinoma <Emphasis>in situ</Emphasis>
(LCIS) is
misleading. This lesion is more appropriately termed lobular
neoplasia.
2) Missing horizontal space for lists
When a paragraph follows a SummarySection there is proper spacing
between
the Title element and the paragraph. However, if a list (OL, UL)
follows
a summary section title the horizontal space is missing.
Example (Breast Cancer Treatment - HP):
http://www.cancer.gov/cancertopics/pdq/treatment/breast/healthprofessional/allpages#Section_88
TREATMENT OPTIONS FOR PATIENTS
1. Observation ...
2. Tamoxifen ...
when the proper display would be
TREATMENT OPTIONS FOR PATIENTS WITH LCIS
1. Observation ...
2. Tamoxifen ...
BZDATETIME::2010-09-20 17:23:35
BZCOMMENTOR::Volker Englisch
BZCOMMENT::36
As discussed at a recent status meeting I was supposed to summarized all of the collected open Gatekeeper/Cancer.gov issues to allow Robin to add individual Bugzilla tasks for these:
Issue 1 - Handling of table borders (Comment #1)
a - Allow table to be displayed with just grid or just frame
(not certain if there might be a need for this)
Issue 2 - Handling of alignment within table cells
a - right/left alignment for individual cell OK but not
alignment on character. (Comment #15)
b - alignment for column not working
Issue 3 - Handling of column width (Comment #15)
It is currently not possible to adjust the column width with our
format. We could use percentages to specify column width but
that's not allowed by the DTD.
Issue 4 - Markup within image captions (Comment #3)
a - Bold, italics, superscript, etc. not working in captions
b - Characters (i.e. "+") are dropped in image captions (Comment
#27)
Issue 5 - Implement new Dictionary data elements (Comment #4)
Issue 6 - Fact Sheet Documents (Comment #5)
Issue 7 - New data elements for CTGOV Protocols (Comment #6)
Issue 8 - Between a Section heading and an immediately following list
a blank
line needs to be added (Comment #35)
Issue 9 - Too much white space between SummarySection and immediately
following
SummarySubSection. (Comment #35)
Issue 10- Gatekeeper processing fails to remove documents from
Cancer.gov
if a redirection link exists for the document. (Comment #31)
Issue 11- Display the HP dictionary terms without pronunciation (Comment #32)
Issue 12- MediaLink in patient definition block is displaying in HP
term
pop-up (Comment #32)
Issue 13- Publishing Genetics Dictionary from the CDR (Comment #32)
Issue 14- Change the behavior for table footers (single row vs.
multi-row
footer). (Comment #34)
We may want to discuss on Thursday which of these items would make sense to be implemented and which might be covered by the new WCM.
BZDATETIME::2010-12-09 16:49:56
BZCOMMENTOR::Volker Englisch
BZCOMMENT::37
Issue 15 - Discovered while working with Glossary Terms (comment copied from OCECDR-3270):
While I was looking into these glossary terms I've noticed (on
Cancer.gov) that
there are 3 terms that are not listed on the A-Z list.
If you list all of the terms (enter % in the search field) one can see
three
terms at the very end of the list starting with a Greek letter: µL, µM,
and
ß-hCG.
These terms are not, however, displayed in any of the sub-lists
available via
the A-Z list because they are neither starting with a letter, nor with
a
number.
I've reported this to the Cancer.gov team (Blair, Chuck, Bryan) since
I figure
they would want to know since it's something that will eventually have
to be
fixed on the new Cancer.gov and we agreed that this issue would be
tracked and
addressed at a later date.
BZDATETIME::2011-01-31 10:26:53
BZCOMMENTOR::Volker Englisch
BZCOMMENT::38
(In reply to comment #32)
> 2. Similar question about the images. The media link is actually in
the
> patient definition block, but is showing in the HP term pop-up
on
> Cancer.gov.
> This is fine but Robin was wondering why it was showing up?
This is not a GateKeeper issue, at least not directly.
Our DTD doesn't allow the MediaLink element to be an element of the TermDefinition or the SpanishTermDefinition. In order to decide if a Media document belongs to the English or Spanish term we're using a language attribute for the MediaLink. In order to also distinguish a MediaLink by audience (HP and Patient) we would need to introduce an additional audience attribute for the MediaLink. Until such an attribute has been added to the DTD (or the DTD has been changed to allow a MediaLink to be contained within a definition) Cancer.gov will not be able to identify an image as one belonging to the HP or the Patient definition.
An example of this is the glossary term pedigree. The concept document CDR620958 has both an English patient and an English HP definition, and there is a media link inside the term definition block of the patient definition. In PublishPreview and on Cancer.gov, the image displays for both, the Patient as well as the HP definition.
BZDATETIME::2011-02-14 15:47:37
BZCOMMENTOR::Volker Englisch
BZCOMMENT::39
We've identified another issue that would need to be corrected as part of the Gatekeeper processing.
If a user is creating a SummaryFragmentRef to a KeyPoint element the link created on Cancer.gov is broken. Currently, the users must create the fragment link to the nearest Section or Para element above the KeyPoint but it would make sense to allow users to link to a KeyPoint directly.
Note: This problem had been mentioned at least once in the
past.
See OCECDR-2503#c10 (Comment 10).
I propose moving this "issue" to a wiki page, as it's not really a good fit for a task to be tracked in JIRA. Comments?
I agree. A wiki page seems to be a better place to capture future enhancements.
Would it make sense if I pulled everything from the issue into a page, for you to edit as you have time, or would it be more appropriate if you created the wiki page from scratch, only including things which are currently on the table?
BZCOMMENT::36 summarizes everything that's still open. We should decide on a good place to put it on the wiki pages.
How about a child page under https://collaborate.nci.nih.gov/display/OCECTBWIKI/CDR ?
I propose moving this "issue" to a wiki page
Done.
https://collaborate.nci.nih.gov/pages/viewpage.action?pageId=112232232
This "Gatekeeper To-Do List" has been exported to the Wiki.
File Name | Posted | User |
---|---|---|
DrugCombo2.html | 2009-05-20 13:12:16 | Englisch, Volker (NIH/NCI) [C] |
Tables.htm | 2009-04-03 15:21:18 | Englisch, Volker (NIH/NCI) [C] |
test_border.html | 2009-04-03 15:57:49 | Englisch, Volker (NIH/NCI) [C] |
test_collapse.html | 2009-04-03 15:56:56 | Englisch, Volker (NIH/NCI) [C] |
test_noCSS.html | 2009-04-03 15:55:25 | Englisch, Volker (NIH/NCI) [C] |
test_noCSS.html | 2009-04-03 15:51:38 | Englisch, Volker (NIH/NCI) [C] |
Elapsed: 0:00:00.001593