CDR Tickets
| Issue Number | 4887 |
|---|---|
| Summary | [Glossary] Links within Levels Of Evidence pop ups |
| Created | 2020-09-14 12:50:41 |
| Issue Type | Improvement |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2020-11-17 14:17:33 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.274703 |
Sometimes, links are created within LOE definitions "See …." but the links are dead within the definitions in pop up. This is probably intentional but I wanted to make sure this really the case.
Example summary: 62898
but the links are dead within the definitions in pop up
This is not exactly correct. A dead link would be text within an anchor tag which has been disabled or a link that's pointing to a page that doesn't exist. In this case, however, there is no link created. The text that is displayed as a link within the GTC document is correctly produced by the vendor filter. I would have to find out where the link gets dropped further downstream.
The filter that's taking the CDR vendor output and converts it for the load to ElasticSearch (CDR800355) has been written to only extract the text of the definition. If I remember correctly that was based on the original requirements.
This requirement is in the app module documentation. We will talk with Amy at next week's meeting about what's involved in getting the requirement changed so the markup is preserved.
Requirements need to be modified to preserve markup in order to convert these ExternalRefs into an HTML link in the HTML version of the definition.
It turns out the LOE links are created via SummaryRef elements which were not included in the conversion document to be transformed into HTML anchor tags. This is a CDR task, so I'm moving this ticket to Maxwell.
The following filter has been updated to include the links to LOEs and external links in glossary definition text:
CDR800355 - Index Glossary Dictionary
https://github.com/NCIOCPL/cdr-server/commit/7497da8
It is difficult to review this on DEV. I am therefore attaching a screenshot to show the result.
Verified on DEV. Thanks!
Verified on QA. Thanks!
I am unable to generate Pub preview for summaries on QA. I get a "Failure generating preview: Not Found" error.
Please give it another try. The test Drupal CMS was in the middle of a rebuild.
I am now getting: "Failure generating preview: Forbidden" error. I restarted XMetal but got same error message.
The PDQ Drupal account's password got changed. Fixed now.
It seems to be working now. Thanks!
~volker How can we test this on QA? I don't see the changes in PP.
In order to test this I will have to make some temporary configuration changes but I can only do those in coordination with the Drupal team or for a short time. Let me know a time that would work for you and we can maybe make those changes for a short time to test.
I am ready. Let me know when it is ready to test. Thanks!
Verified on QA. Thanks!
Verified on Cancer.gov Thanks!
| File Name | Posted | User |
|---|---|---|
| level of evidence links.PNG | 2020-09-14 12:51:53 | Osei-Poku, William (NIH/NCI) [C] |
| Screen Shot 2020-10-16 at 5.26.58 PM.png | 2020-10-16 18:19:28 | Englisch, Volker (NIH/NCI) [C] |
Elapsed: 0:00:00.001439