CDR Tickets

Issue Number 4808
Summary [Glossary] Display of Spanish synonyms
Created 2020-04-08 13:51:08
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2020-04-10 15:40:38
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.259858
Description

Please modify the publishing filters to display the also calleds for Spanish Glossary terms as follows:

1. When there are two or more also called terms and the last term starts with an “i”, use an “e” instead a "y" as the conjuction.
2. When there are two or more also called terms and the last one does not start with an “i”, use a “y”.
3. Also, there shouldn't be a comma before the last term when there are more than 2 terms. (I think this is already in place)

Here are some examples of some of the display issues:

CDR513056

CDR745806

CDR799187

Comment entered 2020-04-10 15:21:21 by Englisch, Volker (NIH/NCI) [C]

When there are two or more also called terms and the last term starts with an “i”

Does the case of the letter matter?

Comment entered 2020-04-10 15:40:29 by Englisch, Volker (NIH/NCI) [C]

I'm assuming the change has to be done for terms starting with "i" as well as "I".

The following filter has been modified:

  • CDR616048 - Vendor Filter: GlossaryTermName

This is ready for review on DEV.

Comment entered 2020-04-16 09:04:42 by Osei-Poku, William (NIH/NCI) [C]

I'm assuming the change has to be done for terms starting with "i" as well as "I".

Yes, that is correct. Thanks!

Verified on DEV. Thanks!

Comment entered 2020-04-16 17:36:46 by Englisch, Volker (NIH/NCI) [C]

While running the diff report between the previous and the modified version I found a bug in the filter that incorrectly set the conjunction when there were more than two alternate terms and the second term started with an "I" (i.e. CDR449953, CDR513055, and CDR630958).

This has been corrected.  The filter has been updated on QA and STAGE.

Please review again on QA before copying the changes to PROD.

Comment entered 2020-04-23 13:14:53 by Englisch, Volker (NIH/NCI) [C]

I'm waiting for the green light from  to copy these changes to PROD.

Comment entered 2020-04-24 08:28:44 by Osei-Poku, William (NIH/NCI) [C]

Please proceed to install on PROD. Thanks!

Comment entered 2020-04-24 14:09:46 by Englisch, Volker (NIH/NCI) [C]

The filter change has been copied to PROD:

  • CDR616048 - Vendor Filter: GlossaryTermName

https://github.com/NCIOCPL/cdr-server/commit/2536627
https://github.com/NCIOCPL/cdr-server/commit/bf41668c

Please verify on PROD and close this ticket.

Comment entered 2020-04-24 17:01:25 by Englisch, Volker (NIH/NCI) [C]

I noticed that the sample documents were not part of the published summary documents.  That's because I forgot to copy the modified filter as a publishable version.  The filter has been updated and summaries will now pick up the modified filter for our publishing jobs.

Comment entered 2020-05-07 11:57:04 by Osei-Poku, William (NIH/NCI) [C]

Verified on PROD. Thanks!

Attachments
File Name Posted User
spanish synonym.png 2020-04-08 13:42:49 Osei-Poku, William (NIH/NCI) [C]
spanish synonym1.png 2020-04-08 13:43:54 Osei-Poku, William (NIH/NCI) [C]
spanish synonym2.png 2020-04-08 13:44:54 Osei-Poku, William (NIH/NCI) [C]

Elapsed: 0:00:00.001517