| Issue Number | 4794 |
|---|---|
| Summary | Some Dictionary Terms Not Displaying Definition Modal on Click |
| Created | 2020-03-05 16:59:34 |
| Issue Type | Task |
| Submitted By | Burack, Lindsay (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2020-03-10 15:36:51 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.257956 |
Found two patient PDQ summaries with some definitions that when clicked, do nothing. This is not the case for all defined terms in the summaries; there are some that do open the definition modal for that term. But there are several definitions that are not working in these patient summaries:
https://www.cancer.gov/types/lung/patient/non-small-cell-lung-treatment-pdq
https://www.cancer.gov/types/lung/patient/small-cell-lung-treatment-pdq
Go to https://www.cancer.gov/types/lung/patient/non-small-cell-lung-treatment-pdq
Click on any of the following terms in the first paragraph:
lungs
bronchi
trachea
lung cancer
alveoli
See that nothing happens
On https://www.cancer.gov/types/lung/patient/small-cell-lung-treatment-pdq, the following terms also do not work as expected:
lungs
bronchi
trachea
bronchioles
alveoli
The expected result is to click on the glossified term and see the term definition modal appear as on overlay on the page.
On https://www.cancer.gov/types/lung/patient/non-small-cell-lung-treatment-pdq,
in the same first paragraph, click carbon dioxide to see
the expected result.
On https://www.cancer.gov/types/lung/patient/small-cell-lung-treatment-pdq,
in the same first paragraph, click organs,
oxygen, pleura to see the expected
result.
I've modified the filter that creates the vendor output for Gatekeeper to remove trailing whitespace. Actually, the function used is normalize-space() which removes extra whitespace at the beginning and end of a string and compacts multiple consecutive whitespace characters into a single one within the string.
The filter change has been tested on DEV and QA and I've hot-fixed the glossary term for lung (CDR270740) on PROD. The definition modal now shows up for lungs.
The following filter has been updated:
CDR271370 - Module: Vendor Filter Templates
https://github.com/NCIOCPL/cdr-server/commit/e6b27718
~buracklb, please verify on PROD.
Please note, there will be about 20 summaries that will be updated as part of this filter change. This is because the updated filter is shared between most vendor filters.
Hi ~volker - the definition modal does show up for lungs. The other terms mentioned in the description still do not work though. Does each term need to be fixed individually? How can we resolve? Thanks!
All other terms with this problem will be picked up to be updated as part of our weekend publishing job. Those should be fixed by around 6pm tonight.
~buracklb , the publishing job is still running at this time but most of the broken links for the sample summary are not updated.
Please verify and close this ticket if everything looks good.
Verified on Cancer.gov.
Closing ticket.
Elapsed: 0:00:00.001238