| Issue Number | 4789 |
|---|---|
| Summary | [Summaries] Summaries Metadata Report - Add Module Options |
| Created | 2020-02-27 12:03:36 |
| Issue Type | Improvement |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Kline, Bob (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2020-05-21 15:34:49 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.257503 |
We would like to add the following options to this report (for the multiple summaries by group flavor of the report):
Summaries and modules
Summaries only
Modules only
Do you agree that the new options should only be used when reporting on multiple summaries, ~juther?
Yes, this only applies to the "multiple summaries by Group" option of the report.
The original implementation of this report required that English summaries selected for a given board be publishable and not blocked, but didn't apply that same approach for Spanish summaries (in fact, if Spanish were selected, the implementation avoided Spanish summaries for which the English originals of which they were the translations did not meet those criteria, but the criteria were not applied to the Spanish translated summaries which were the actual subject of the report). I assume that was a mistake, and I'm correcting it. Please let me know if it was actually done that way intentionally (though I would have hoped that if you had told the programmer to do it that way, he would have said so in the code's comments 😉).
Fixing another bug while I'm at it: for some boards asking for Pretty URL or Summary Keywords causes the report to fail.
Implemented on DEV.
Could you indicate in the output if a summary is also marked as a module? That is available as module.
indication added to the title
Could you please bold the indication and change the parenthesis to brackets instead? Thanks! Final request. I promise 😃.
As discussed in the status meeting, please also change the parenthetical indication to "(module)". Thanks.
Adding the indication is relatively straightforward. Making it bold is not, in the context of this particular report, so that will need to go in a separate Maxwell ticket.
~juther was it intentional that your version went back to parentheses? Or is it OK to use square brackets as William requested?
Also, FYI, here's at least a partial list of admin scripts which
select based on the ModuleOnly attribute rather than the
AvailableAsModule attribute.
ChangesToSummaries.py
PdqBoards.py
publishing.py
SummariesLists.py
SummariesWithMarkup.py
SummaryCRD.py
translation-job.py
No, that wasn't intentional. Brackets are fine.
Thank you! This is helpful.
Module label modified.
Verified on DEV. Thanks!
Agreed - this looks good to me too. Thanks.
~juther We've looked at this on QA and it looks good. Thanks!
Agreed - verified on QA. Thanks!
Verified on PROD.
Elapsed: 0:00:00.002112