CDR Tickets

Issue Number 4699
Summary Correspondence Mailers not working
Created 2019-11-13 11:02:12
Issue Type Bug
Submitted By Shields, Victoria (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2019-11-13 16:04:17
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.252285
Description

The Letter and Board Members fields do not populate, even after you choose a Board.

Comment entered 2019-11-13 15:09:30 by Kline, Bob (NIH/NCI) [C]

I've been scratching my head on this one. Works fine on https://cdr-dev2.cancer.gov/cgi-bin/cdr/BoardMemberMailerReqForm.py and the code is identical. I'll keep digging. if you want to dig in and see you can figure out what's going on, feel free to join the fun. 🙂

Comment entered 2019-11-13 16:04:17 by Kline, Bob (NIH/NCI) [C]

Yay! I found it (a configuration problem). Please try again.

Comment entered 2019-11-13 16:16:55 by Shields, Victoria (NIH/NCI) [E]

I took a very quick look (without testing anything yet). The fields are populated in Chrome and Firefox, but not IE. Should we just test the browsers that work for now?

Comment entered 2019-11-13 16:40:35 by Kline, Bob (NIH/NCI) [C]

: can you test with Internet Explorer in your Parallels Windows? I don't have access to an IE that's not subject to the extra constraints CBIIT imposes on its servers. It doesn't look as if IE is loading /js/BoardMemberReqForm.js at all.

Comment entered 2019-11-13 16:41:52 by Kline, Bob (NIH/NCI) [C]

You can test on browsers that aren't broken, but be aware that we might have to change to software if we have to support IE and there's no other way to do that.

Comment entered 2019-11-13 16:46:27 by Englisch, Volker (NIH/NCI) [C]

I attached the screenshot of what I see when I open the correspondence mailer page.

Comment entered 2019-11-13 16:56:33 by Englisch, Volker (NIH/NCI) [C]

I've tried it in Parallels and on my DEV-VM.  The Letter and Board Member fieldset doesn't populate with IE but works OK in FF.

Comment entered 2019-11-13 17:13:08 by Englisch, Volker (NIH/NCI) [C]

I'm seeing the following JS error reported by IE:

SCRIPT1010: Expected identifier
BoardMemberMailerReqForm.js (23,17)

This is pointing to the following line:
   let [name, key] = letter;

Comment entered 2019-11-13 17:13:27 by Kline, Bob (NIH/NCI) [C]

 Try again, please. It turns out that IE is way behind all the other browsers in its JavaScript support, so I had to dumb down the code for it. 😛

Comment entered 2019-11-13 17:19:14 by Kline, Bob (NIH/NCI) [C]

Yeah, Microsoft is way behind the rest of the browser world. I have dumbed down the code to accommodate them. 😉

Comment entered 2019-11-13 17:21:45 by Englisch, Volker (NIH/NCI) [C]

Dumb code works.

Comment entered 2019-11-13 17:58:47 by Shields, Victoria (NIH/NCI) [E]

IE is still not working for me. I have IE 11.

Comment entered 2019-11-13 18:10:19 by Kline, Bob (NIH/NCI) [C]

Can you make sure the browser isn't caching an old copy of the JavaScript? Hold down the shift key while pressing F5.

Comment entered 2019-11-13 18:11:08 by Kline, Bob (NIH/NCI) [C]

If that doesn't work, could you swing by Victoria's office and see if you can figure it out, ?

Comment entered 2019-11-13 18:26:05 by Englisch, Volker (NIH/NCI) [C]

It's all good. A reload did it.

Comment entered 2019-11-13 18:26:58 by Shields, Victoria (NIH/NCI) [E]

It's working now. Although I closed all of my IE windows and logged in again, I didn't refresh the page. 🙁

Comment entered 2019-11-13 18:30:13 by Kline, Bob (NIH/NCI) [C]

Good news! 😉

Comment entered 2019-11-15 14:57:33 by Shields, Victoria (NIH/NCI) [E]

We have not been able to run any mailers. The fields are now populated, but no one has been able to run a report. We get an error code:

 

Job 17570 of this publication type is still pending

Comment entered 2019-11-15 15:10:25 by Kline, Bob (NIH/NCI) [C]

I have marked job 17570 as failed. Please try again.

Comment entered 2019-12-09 14:19:54 by Juthe, Robin (NIH/NCI) [E]

Verified on QA2. Correspondence mailers are working as expected.

Comment entered 2020-02-27 10:48:31 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD.

Attachments
File Name Posted User
Screen Shot 2019-11-13 at 16.45.08.png 2019-11-13 16:45:44 Englisch, Volker (NIH/NCI) [C]

Elapsed: 0:00:00.001553