| Issue Number | 4390 |
|---|---|
| Summary | [Misc Docs] Misc Doc QC Report Missing Glossary Terms and Placeholder Text |
| Created | 2018-01-17 16:24:33 |
| Issue Type | Bug |
| Submitted By | Juthe, Robin (NIH/NCI) [E] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2018-05-31 17:26:39 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.219878 |
The miscellaneous document QC report is missing linked glossary terms. The linked text is missing altogether.
Example: CDR0000584249 - Patient Summary Fragments
I'll attach a screenshot.
I will be surprised if this isn't the same bug I fixed for OCECDR-4389.
It's not. We'll keep investigating.
Placeholder text also does not display on the QC report. (see attachment)
However, this issue appears to be on PROD as well, so I'm moving this into Hawking.
~juther, what should be displayed for the placeholder on the QC report? Just the name of the placeholder or PlaceHolder?
Is it possible to display the actual text? In the examples above, the missing text is a linked glossary term. Ideally, we'd like to see the linked term in the text.
Absolutely, for the case when the GlossaryTermRef is missing we're including the element's text but in the case when the PlaceHolder is missing I don't know what to replace it with. In XMetaL we're displaying [ClinicalTrialSearchLink] or whatever name attribute you gave the PlaceHolder.
Are we going to display the same in the QC report?
Ah, I see. Yes, let's display the same filler text for the placeholder element on the QC report. We'll probably need to look at some examples of this to be sure it works for the different types of placeholder elements that could be present, but that seems like a reasonable place to start. Thanks.
In the summaries the glossaries are linking to the Glossary QC
reports.
Are we doing the same here? Will there be markup to account for or do we
just want to see the text?
The following filters have been modified on DEV to display the PlaceHolder text and GlossaryTermRef elements:
CDR000154: Miscellaneous Document Report Filter
CDR335169: Module: STYLE Default
We decided it will be fine to just show the text.
The changes have been uploaded to github to the branch
cdr4390-miscdoc:
https://github.com/NCIOCPL/cdr-server/commit/d27291d
This is ready for review on DEV.
~juther, where you able to
take a look at the misc doc QC report on DEV?
Since this is a small change I would like to put the filter changes on
PROD prior to refreshing the CDR database.
Is it safe to look on DEV now?
Yes, as far as I know. Bob reported the restore of the archive DB was done.
Thanks. This looks good to me on DEV!
Those filter changes listed above have been copied to QA, STAGE, and PROD.
Please verify on PROD and close this ticket.
Verified on PROD. Thanks!
| File Name | Posted | User |
|---|---|---|
| misc doc placeholders.png | 2018-01-18 13:57:13 | Juthe, Robin (NIH/NCI) [E] |
| misc doc qc report.png | 2018-01-17 16:26:51 | Juthe, Robin (NIH/NCI) [E] |
Elapsed: 0:00:00.001453