| Issue Number | 4159 |
|---|---|
| Summary | Modify QC Report filters to not display Module Changes Section in main Summary QC reports |
| Created | 2016-09-30 12:44:42 |
| Issue Type | Improvement |
| Submitted By | Osei-Poku, William (NIH/NCI) [C] |
| Assigned To | Englisch, Volker (NIH/NCI) [C] |
| Status | Closed |
| Resolved | 2017-02-02 17:04:42 |
| Resolution | Fixed |
| Path | /home/bkline/backups/jira/ocecdr/issue.195403 |
Users reported that when a "Changes to This Summary " section is placed in markup in a module document, it is displayed in QC reports of summaries that have links from the module. I was able to reproduce this behavior on DEV with the following documents:
1. Module - CDR0000751732
2. Summary - CDR0000062908
Could you please look into this ?
What would you expect to happen?
Is the problem that the Changes-section displays when it's in markup
but does not display when it's not in markup?
Is the problem that the Changes-section is not included in the parent
document or something else?
I'm not surprised by the current behavior. I wouldn't have expected a changes section to be included in a module-only module.
The problem is that the changes section displays in the QC report of the parent summary when it's in markup in the module doc but it does not display in the parent summary when it's not in markup (i.e., once it been published). The expectation is that the changes section should not display in the parent summary, regardless of the markup. We have been adding changes sections to module-only modules as a way to track changes to the module (for internal purposes).
That is right, Robin. We do not want the Changes Section of the Module document displaying in the Summary QC report and it appears to be doing the right thing (when not in markup). The problem appears to occur when you put the Changes section in markup. That makes it display in the QC report of the summary document, which should not be the case.
That does sound like a problem and I'm not going to ask why we're using markup for internal text.
This sounds like a filter change - release independent.
Updated title to reflect changes requested
The following filter has been modified to suppress the Changes section:
CDR712005: Denormalization Filter: Summary Module
This is ready for review on DEV.
~bkline I'm checking this modified filter. According to the comment I did not save it in subversion (I usually add the revision number if I do and I don't see a log message) but it appears the filter is now in trunk and made it to PROD as part of the merge.
~oseipokuw, could you please confirm that these changes are on PROD as part of Einstein?
You checked it into Einstein as r14573.
Yes, this one I understand based on the logs but I don't understand what I was thinking. It's in the release-independent queue, so if I were Volker I would have made the changes in trunk and not version it in Subversion until it went to PROD. Maybe I thought I could just as well include it in Einstein but I didn't move it to the IT-1/IT-2 sprint and I didn't add a comment so that this change could be tested as part of Einstein.
Of course, another likely explanation could be that Jira ate my comment or was acting up when I did try to enter it before I was rushing out to another tennis match and then I forgot about the update by the next morning.
Anyway, ~oseipokuw, please take a look at this on PROD. This is a change to the QC filters and wouldn't affect the vendor output. If it looks OK on PROD I don't think there's anything else that needs to be done here.
Yes, it looks good. It appears the problem has been fixed. Thank you!
Since ~oseipokuw reported the problem as fixed in March I'm closing the ticket.
Elapsed: 0:00:00.001356