CDR Tickets

Issue Number 4000
Summary [Summaries] Patient Summary QC Reports and "Show All Content" Message
Created 2015-11-17 10:50:21
Issue Type Bug
Submitted By Juthe, Robin (NIH/NCI) [E]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2015-11-17 11:23:25
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.173839
Description

We are getting the "show all content" message when running Patient RLSO QC reports on PROD. Given how frequently these reports are run and how it requires running each one a second time, I don't think we should wait for Darwin, especially if the fix is straightforward. Let's discuss.

Comment entered 2015-11-17 11:08:45 by Kline, Bob (NIH/NCI) [C]

I didn't get that message. Any hints for how to reproduce the behavior? I brought up CDR45962 using this URL.

Comment entered 2015-11-17 11:13:02 by Kline, Bob (NIH/NCI) [C]

Ah, you're running Internet Explorer, I'll bet.

Comment entered 2015-11-17 11:23:26 by Kline, Bob (NIH/NCI) [C]

Fixed on DEV, I think. Please test.

Comment entered 2015-11-17 15:08:31 by Englisch, Volker (NIH/NCI) [C]

It's working for me. The message magically disappeared.

Bob, when I asked you if you had modified both filters you said 'Yes' meaning both, the RS and BU filters when I had thought about the HP and the patient filters. The HP filters didn't show that problem because they didn't use the script tag. I can't remember why the script tag had been added to the patient filters but I believe it would be good (meaning: less confusing) if the HTML headers for all four filters would be identical if possible.

If it were me I would modify the other two filters as well, just for fun.

Comment entered 2015-11-17 16:03:03 by Kline, Bob (NIH/NCI) [C]

Be my guest. I just searched for the string "googleapi" in all our filters and modified the two that matched the search. Please check the changes into trunk, as Robin has asked us to get this directly onto production, without waiting for the next release.

Comment entered 2015-11-17 16:37:18 by Englisch, Volker (NIH/NCI) [C]

The following filters have been updated:

  • R13566: CDR0000000079.xml (Health Professional Summary Report)

  • R13566: CDR0000000153.xml (Health Professional Summary Report-Bold/Underline)

Comment entered 2015-11-18 17:18:19 by Kline, Bob (NIH/NCI) [C]

If we're shooting for consistency, you might consider making the reports use HTML 5, as our new report harness classes do.

Comment entered 2015-12-03 18:01:07 by Juthe, Robin (NIH/NCI) [E]

This looks good to me on DEV. I've asked Victoria and Diana to take a look too since they reported the problem.

Comment entered 2015-12-07 12:13:51 by Juthe, Robin (NIH/NCI) [E]

Victoria and Diana confirmed that they are not seeing this message on DEV, either. I think this can be promoted. Thanks.

Comment entered 2015-12-30 13:48:08 by Englisch, Volker (NIH/NCI) [C]

The 4 summary QC report filters have been promoted to PROD and all are using HTML 5 headers now:

  • R13628: CDR0000441144.xml - Patient Summary QC Report - Bold/Underline

  • R13628: CDR0000000158.xml - Patient Summary QC Report Filter

  • R13577: CDR0000000153.xml - Health Professional Summary Report-Bold/Underline

  • R13577: CDR0000000079.xml - Health Professional Summary Report

Please verify on PROD and close this ticket.

Comment entered 2016-01-21 12:11:03 by Juthe, Robin (NIH/NCI) [E]

Verified on PROD.

Elapsed: 0:00:00.001459