CDR Tickets

Issue Number 3696
Summary Beginning of Year Bug
Created 2014-01-06 16:42:46
Issue Type Bug
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2014-03-26 19:07:18
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.116776
Description

The first week of a year is defined as that week (beginning on Monday) with the first Thursday. When creating the auxiliary files for our licensees on the FTP server we're using the week number as part of the updated files created. The data delivered is always the data for the previous week.
In order to correctly create the file names even when publishing is delayed I'm creating the file names based on a day 5 days ago. This works properly during the year but not for the first week of the year if the 4th is on a Saturday or Sunday.

I need to make small changes to the program to adjust for this

Comment entered 2014-03-26 19:07:04 by Englisch, Volker (NIH/NCI) [C]

The following programs have been updated to fix this once-a-year bug:

  • R12500: copyData2Pub.py

  • R12500: createStatFiles.py

  • R12500: getSummaryLanguage.py

This has been implemented on DEV. I will have to run a weekly publishing job to ensure I didn't break anything. The real test will come on the first Friday of next year.

Comment entered 2014-03-27 16:56:53 by Englisch, Volker (NIH/NCI) [C]

After fixing a minor bug last night this ran successfully on DEV:

  • R12502: copyData2Pub.py

  • R12502: createStatFiles.py

Comment entered 2014-03-28 14:33:26 by Englisch, Volker (NIH/NCI) [C]

After fixing a minor bug last night this ran successfully on DEV

This statement was only half true. There was an error that only showed up as a warning. The production process didn't fail (technically) but it also didn't do everything. I've modified another program to fix this:

  • R12526: extractExportData.py

I've also added the property keywords in Subversion, so we may want to include a few more files in the patch to include the updated keywords.

I'm marking this as verified.

Comment entered 2014-05-01 17:46:31 by Englisch, Volker (NIH/NCI) [C]

I'm not going to wait for the beginning of next year before closing this issue but I'm going to wait until the next weekend publishing job finished successfully.

Comment entered 2014-05-13 11:50:53 by Englisch, Volker (NIH/NCI) [C]

The code that was part of the release introduced a different bug that had been fixed last week. The publishing job ran OK over the weekend and I'm closing this issue.

Elapsed: 0:00:00.001493