CDR Tickets

Issue Number 3308
Summary [Internal] Add Field "Expired" to "Manage Users" Page
Created 2011-02-15 18:07:14
Issue Type Improvement
Submitted By Englisch, Volker (NIH/NCI) [C]
Assigned To Englisch, Volker (NIH/NCI) [C]
Status Closed
Resolved 2011-03-10 14:10:39
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107636
Description

BZISSUE::5000
BZDATETIME::2011-02-15 18:07:14
BZCREATOR::Volker Englisch
BZASSIGNEE::Volker Englisch
BZQACONTACT::Alan Meyer

In order to disable a user account the date field 'expired' has to be populated.

We should be able to enter the date field as via our 'Edit User Info' admin page.

Comment entered 2011-02-18 14:38:54 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-18 14:38:54
BZCOMMENTOR::Volker Englisch
BZCOMMENT::1

I found out from William that he is "deleting" users through the User Admin interface. When the "Delete User" button is pressed on the "Edit User Information" page, the expiration date of the user record is being populated with the current date and that user's record will not be displayed anymore.

Bob, you asked me to disable users which I did by manually setting their expiration date to some date in the past.
Are we OK with disabling a user account given the current functionality (setting today's date as expiration date) or do we want to enhance the function to allow specifying any date in the past?

Comment entered 2011-02-18 14:47:28 by alan

BZDATETIME::2011-02-18 14:47:28
BZCOMMENTOR::Alan Meyer
BZCOMMENT::2

(In reply to comment #1)
> I found out from William that he is "deleting" users through the User Admin
> interface. When the "Delete User" button is pressed on the "Edit User
> Information" page, the expiration date of the user record is being populated
> with the current date and that user's record will not be displayed anymore.
>
> Bob, you asked me to disable users which I did by manually setting their
> expiration date to some date in the past.
> Are we OK with disabling a user account given the current functionality
> (setting today's date as expiration date) or do we want to enhance the function
> to allow specifying any date in the past?

I haven't checked, but it may be that the transaction initiated by the web interface is audited, which is a good thing. Also, using today's date is more accurate. It may be true that a user left a month ago but if his account wasn't disabled until today, then it was disabled today, not a month ago. If some use was made of the account between a month ago and today we will have an anomaly in the data - an apparently expired account performed some action.

Comment entered 2011-02-18 15:05:20 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2011-02-18 15:05:20
BZCOMMENTOR::Bob Kline
BZCOMMENT::3

Ah! Looks like we did the Right Thing to start with. No need to provide for specifying a date in the past.

Comment entered 2011-02-21 17:00:18 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-21 17:00:18
BZCOMMENTOR::Volker Englisch
BZCOMMENT::4

Would it make sense to modify the label on the button from 'Delete User' to 'Disable User' since that's what we're doing?

Comment entered 2011-02-21 17:03:59 by alan

BZDATETIME::2011-02-21 17:03:59
BZCOMMENTOR::Alan Meyer
BZCOMMENT::5

(In reply to comment #4)
> Would it make sense to modify the label on the button from 'Delete User' to
> 'Disable User' since that's what we're doing?

That sounds better, though it also sounds a little like we're going to break his legs. How about "Inactivate user"?

Comment entered 2011-02-21 17:15:57 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2011-02-21 17:15:57
BZCOMMENTOR::Bob Kline
BZCOMMENT::6

Either is OK with me.

Comment entered 2011-02-21 17:28:57 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-02-21 17:28:57
BZCOMMENTOR::Volker Englisch
BZCOMMENT::7

I've renamed the button to 'Inactivate User'. Since this was merely a change to the label I went ahead and copied the program to FRANCK and BACH.
EditUser.py - R10035

Please verify on BACH and close this bug.

Comment entered 2011-03-10 14:10:39 by Englisch, Volker (NIH/NCI) [C]

BZDATETIME::2011-03-10 14:10:39
BZCOMMENTOR::Volker Englisch
BZCOMMENT::8

Since our QA person is on vacation I took on the challenge, confirmed this on BACH and I'm closing the issue.

Elapsed: 0:00:00.001829