CDR Tickets

Issue Number 3159
Summary [CTgov] Possible changes to ctgov import software
Created 2010-05-20 11:31:03
Issue Type Improvement
Submitted By Osei-Poku, William (NIH/NCI) [C]
Assigned To Kline, Bob (NIH/NCI) [C]
Status Closed
Resolved 2010-06-29 13:30:51
Resolution Fixed
Path /home/bkline/backups/jira/ocecdr/issue.107487
Description

BZISSUE::4846
BZDATETIME::2010-05-20 11:31:03
BZCREATOR::William Osei-Poku
BZASSIGNEE::Bob Kline
BZQACONTACT::William Osei-Poku

This issue came up as a result of OCECDR-3139. I am adding the email communications we've had so far to this issue so that it will be easy to track.

---Original Message---
From: Grama, Lakshmi (NIH/NCI) [E] lgrama@mail.nih.gov
Sent: Tuesday, May 11, 2010 1:57 PM
To: Osei-Poku, William
Cc: Kline, Robert (NCI)
Subject: RE: Possible change to ctgov import software

I don't think it is a good idea to add the PDQPerson block automatically because there may be investigators that we will never map and you will have to remove the blank elements. Remember any changes to the import program affect all protocols not just the transferred trials. Bob, Alan. Volker and I discussed some options - let us talk more on Thursday

---Original Message---
From: Osei-Poku, William wOsei-Poku@icfi.com
Sent: Monday, May 10, 2010 4:12 PM
To: Grama, Lakshmi (NIH/NCI) [E]
Cc: Kline, Robert (NCI)
Subject: Possible change to ctgov import software

Hi Lakshmi,
Please see my comments/request about the new macro below and Bob's response. We will need to make changes to the import software to allow empty PDQPerson elements in the case of Investigators and officials only. This will make the use of the person macro even more useful.

> In order to use the person macro, we need to manually add the PDQPerson
> elements (CTGovProtocol/Sponsors/OverallOfficial/PDQPerson &
> CTGovProtocol/Location/Investigator/PDQPerson) first because when the documents
> are imported, these elements are not part of the default template. It will be
> helpful to have these 2 elements in the default template when the documents are
> first imported. This will save the users’ additional time since they have to
> manually add the elements before doing a search for the persons. I believe
> this is a CSS/Template change and should go to Volker, right?

The import software doesn't use the XMetaL templates. XMetaL is a program used
by humans to create and modify XML documents. The import program processes the
protocol documents in the middle of the night, without any human involvement.
If you want the CT.gov import software to change the structures it creates when
importing new documents, please create a new Bugzilla issue telling us what you
want (assuming this gets approved by Lakshmi, who I believe was the one who
told us that we weren't that concerned about mapping NLM's persons, and that we
should therefore omit those elements when we didn't have mappings).

–
Configure bugmail: http://verdi.nci.nih.gov/tracker/userprefs.cgi?tab=email
----— You are receiving this mail because: -------
You are the QA contact for the bug.
You reported the bug.

Thanks,
William

Comment entered 2010-05-21 14:15:37 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-05-21 14:15:37
BZCOMMENTOR::Bob Kline
BZCOMMENT::1

Lakshmi will review this issue and discuss it further at the next meeting.

Comment entered 2010-06-01 11:59:05 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-06-01 11:59:05
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::2

(In reply to comment #0)
> I don't think it is a good idea to add the PDQPerson block automatically
> because there may be investigators that we will never map and you will have to
> remove the blank elements. Remember any changes to the import program affect
> all protocols not just the transferred trials. Bob, Alan. Volker and I
> discussed some options - let us talk more on Thursday
>
>
I just wanted to clarify that for every PDQPerson that is an <Investigator> or <OverallOfficial>, we manually add the <PDQPerson> element, check to see if they are in the CDR and link them, if they are not in the CDR, we manually delete the element. We do this for both transfer protocols and new protocols. So adding the PDQPerson element automatically for Investigators and OverallOfficials (not PDQPerson for <Contact> or <ContactBackup>) will at least save us the time for adding the element.

Comment entered 2010-06-17 16:41:26 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-06-17 16:41:26
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::3

Last week, Lakshmi said we can proceed with this change. We discussed that the PDQPerson element should be added for only <Investigator> and <OverallOfficial> elements

Comment entered 2010-06-21 12:32:23 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-06-21 12:32:23
BZCOMMENTOR::Bob Kline
BZCOMMENT::4

Filter changes installed on Mahler. I have run a download job on Mahler, so there should be some new trials to review in the interface page. After you've approved some of them I'll run an import job.

Comment entered 2010-06-21 16:03:52 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-06-21 16:03:52
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::5

(In reply to comment #4)
> Filter changes installed on Mahler. I have run a download job on Mahler, so
> there should be some new trials to review in the interface page. After you've
> approved some of them I'll run an import job.

Please proceed with the import job. I have marked a few for import.

Comment entered 2010-06-21 16:27:04 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-06-21 16:27:04
BZCOMMENTOR::Bob Kline
BZCOMMENT::6

(In reply to comment #5)

> Please proceed with the import job.

Done.

Comment entered 2010-06-22 13:14:10 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-06-22 13:14:10
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::7

I have looked at the documents and they look good. The PDQPerson element is showing correctly for investigators and overallcontacts. However, the temporary texts in curly brackets which we often find in empty elements are missing from the elements. Could that be included?

Comment entered 2010-06-22 14:06:44 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-06-22 14:06:44
BZCOMMENTOR::Bob Kline
BZCOMMENT::8

Tell me what you want it to say.

Comment entered 2010-06-22 14:48:18 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-06-22 14:48:18
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::9

(In reply to comment #8)
> Tell me what you want it to say.

{PDQPerson}

Comment entered 2010-06-24 09:15:19 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-06-24 09:15:19
BZCOMMENTOR::Bob Kline
BZCOMMENT::10

Filter modified again. After you've marked some additional trials for import, I'll run another job on Mahler.

Comment entered 2010-06-24 12:23:02 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-06-24 12:23:02
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::11

(In reply to comment #10)
> Filter modified again. After you've marked some additional trials for import,
> I'll run another job on Mahler.

Done. OK to run the import job.

Comment entered 2010-06-24 18:45:19 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-06-24 18:45:19
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::12

Verified on Mahler. Please promote to Bach.

Comment entered 2010-06-25 11:01:57 by Kline, Bob (NIH/NCI) [C]

BZDATETIME::2010-06-25 11:01:57
BZCOMMENTOR::Bob Kline
BZCOMMENT::13

Promoted to Bach; please check (and close if OK).

Comment entered 2010-06-29 13:30:51 by Osei-Poku, William (NIH/NCI) [C]

BZDATETIME::2010-06-29 13:30:51
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::14

(In reply to comment #13)
> Promoted to Bach; please check (and close if OK).

Verified on Bach. Issue closed. Thanks!

Elapsed: 0:00:00.000931