Issue Number | 2751 |
---|---|
Summary | [Glossary] - GTC by English Definition Status report |
Created | 2008-12-31 11:54:43 |
Issue Type | Improvement |
Submitted By | priced |
Assigned To | Kline, Bob (NIH/NCI) [C] |
Status | Closed |
Resolved | 2009-01-16 09:55:43 |
Resolution | Won't Fix |
Path | /home/bkline/backups/jira/ocecdr/issue.107079 |
BZISSUE::4426
BZDATETIME::2008-12-31 11:54:43
BZCREATOR::Sheri Khanna
BZASSIGNEE::Bob Kline
BZQACONTACT::William Osei-Poku
The GTC by English Definition Status Report is shows markup, but it will only show markup of a pronunciation (such as for any new pronunciation) when the insertion tags are inside the TermPronunciation element in the GTN. However, by adding the insertion tags inside the element so that it will show on this report, the publish preview for the term now shows empty parentheses: “diverticulosis ()”.
Could this report be fixed to have the report show markup when the tags are outside of the pronunciation element?
BZDATETIME::2009-01-09 11:46:12
BZCOMMENTOR::Bob Kline
BZCOMMENT::1
Can you put an example of this on Mahler?
BZDATETIME::2009-01-13 13:21:09
BZCOMMENTOR::William Osei-Poku
BZCOMMENT::2
(In reply to comment #1)
> Can you put an example of this on Mahler?
>
Please take a look at the report on Mahler (Start Date: '2009-01-06', End Date: '2009-01-13', Definition Status: 'Approved', Audience: 'Patient').
I tested with CDR0000044962. I currently have the insertion markup wrapped around the TermPronunciation element but nothing shows up on the report. However, if I insert the markup within the Termpronunciation element, the markup correctly shows up on the report.
BZDATETIME::2009-01-13 16:13:13
BZCOMMENTOR::Bob Kline
BZCOMMENT::3
This is similar to the code we wrote for the "Spanish Glossary Terms By Status" report (see issue #1861, in particular comment #18). In that task, it was agreed that users would place all the markup inside the target elements, not outside them. The problem with having the revision markup outside the element we're looking for is that the task of finding the target element is made dramatically more complex by the unlimited possibilities of where the Insertion or Deletion wrappers can appear (in the worst case, it could be above the GlossaryTermConcept element). If you don't care about displaying both the approved/published and the proposed data, then we can just run the document through the filter which applies the revision markup. But I had assumed that for this report you wanted to see both. You might want to work on this problem by tackling the publish preview display. As long as the correct parameter is passed to the revision filtering filter, that display should show you whichever version of the data you want to see (approved, published, proposed, rejected). I'm copying Volker on this issue, so he can assist with any modifications to the publish preview interface needed to expose that level of control for the users.
BZDATETIME::2009-01-16 09:53:31
BZCOMMENTOR::Bob Kline
BZCOMMENT::4
Set resolution in accordance with discussion at yesterday's status meeting.
BZDATETIME::2009-01-16 09:55:43
BZCOMMENTOR::Bob Kline
BZCOMMENT::5
Changed my mind; "WONTFIX" is a better value than "INVALID" here.
Changing status to 'Closed' to kick it off our list of things to do.
Elapsed: 0:00:00.001775